You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2011/07/08 22:13:16 UTC
[jira] [Commented] (LUCENE-3282) BlockJoinQuery: Allow to add a
custom child collector, and customize the parent bitset extraction
[ https://issues.apache.org/jira/browse/LUCENE-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062151#comment-13062151 ]
Michael McCandless commented on LUCENE-3282:
--------------------------------------------
This looks great Shay!
What was the use case for subclassing to translate the filter into OBS? Is it a custom filter cache? Makes me nervous because the app really should create & reuse this OBS filter, usually...
On the Collector: we try to keep our Querys IR-state-free... so it makes me nervous to stick a Collector right on the Query. Can we add a CollectorProvider that the Query invokes when it makes the Weight/Scorer?
Instead of NoOpCollector can we just check for null?
> BlockJoinQuery: Allow to add a custom child collector, and customize the parent bitset extraction
> -------------------------------------------------------------------------------------------------
>
> Key: LUCENE-3282
> URL: https://issues.apache.org/jira/browse/LUCENE-3282
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/search
> Affects Versions: 3.4, 4.0
> Reporter: Shay Banon
> Attachments: LUCENE-3282.patch
>
>
> It would be nice to allow to add a custom child collector to the BlockJoinQuery to be called on every matching doc (so we can do things with it, like counts and such). Also, allow to extend BlockJoinQuery to have a custom code that converts the filter bitset to an OpenBitSet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org