[jira] [Commented] (GEODE-6826) Refactor TcrConnection::readMessageChunked

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-6826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16857091#comment-16857091 ] 

ASF subversion and git services commented on GEODE-6826:
--------------------------------------------------------

Commit 644ddb11b64d0141bceedec38cf53f5103cb81d0 in geode-native's branch refs/heads/develop from Blake Bender
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=644ddb1 ]

GEODE-6826: Refactor chunk processing (#490)

* Move struct definition out of class method
* Move timeout calculation into helper method
* eliminate unnecessary variables
* Move response header reading code into separate method
* Move chunk header reading code into separate method
* Move chunk body reading code into separate method
* switch from raw buffer to std::vector in chunk body code
* do loop now becomes a while loop

Co-authored-by: Steve Sienkowski <ss...@pivotal.io>


> Refactor TcrConnection::readMessageChunked
> ------------------------------------------
>
>                 Key: GEODE-6826
>                 URL: https://issues.apache.org/jira/browse/GEODE-6826
>             Project: Geode
>          Issue Type: Improvement
>          Components: native client
>            Reporter: Blake Bender
>            Priority: Major
>          Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> Having debugged through a problem in this code recently, I can state with authority that it is nigh onto unreadable in its current state, and needs to be refactored into several helper methods to obviate the logic.  The task being performed here is not complex, so the code to perform it needs to reflect that.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)