You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by michaelandrepearce <gi...@git.apache.org> on 2018/02/01 08:10:01 UTC

[GitHub] activemq-artemis pull request #1827: Improve paged message acknowledge

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1827#discussion_r165282202
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/RefsOperation.java ---
    @@ -152,14 +153,14 @@ protected void rollbackRedelivery(Transaction tx, MessageReference ref, long tim
        @Override
        public void afterCommit(final Transaction tx) {
           for (MessageReference ref : refsToAck) {
    -         synchronized (ref.getQueue()) {
    --- End diff --
    
    if this is removed should the same syn block on the queue in rollback be removed, im not 100% if this is safe though or not, is there a concurrent test case at all around this if not, could one be easily added?


---