You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "redlsz (via GitHub)" <gi...@apache.org> on 2023/11/06 13:11:37 UTC
[PR] [ISSUE #7540] Fix query offset of compaction topic [rocketmq]
redlsz opened a new pull request, #7541:
URL: https://github.com/apache/rocketmq/pull/7541
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #7540
### Brief Description
Check the cleanup policy of the topic when processing offset query request in message store.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #7540] Fix query offset of compaction topic [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7541:
URL: https://github.com/apache/rocketmq/pull/7541#issuecomment-3499918623
This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #7540] Fix query offset of compaction topic [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #7541: [ISSUE #7540] Fix query offset of compaction topic
URL: https://github.com/apache/rocketmq/pull/7541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #7540] Fix query offset of compaction topic [rocketmq]
Posted by "leizhiyuan (via GitHub)" <gi...@apache.org>.
leizhiyuan commented on PR #7541:
URL: https://github.com/apache/rocketmq/pull/7541#issuecomment-1884432382
any update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #7540] Fix query offset of compaction topic [rocketmq]
Posted by "redlsz (via GitHub)" <gi...@apache.org>.
redlsz commented on PR #7541:
URL: https://github.com/apache/rocketmq/pull/7541#issuecomment-1794846784
@ltamber PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #7540] Fix query offset of compaction topic [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7541:
URL: https://github.com/apache/rocketmq/pull/7541#issuecomment-1794846052
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7541?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#7541](https://app.codecov.io/gh/apache/rocketmq/pull/7541?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (7501bb5) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/46962c262c37554ff09afe9e02c7baf66a5ecc73?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (46962c2) will **increase** coverage by `0.29%`.
> Report is 1 commits behind head on develop.
> The diff coverage is `80.00%`.
```diff
@@ Coverage Diff @@
## develop #7541 +/- ##
=============================================
+ Coverage 42.97% 43.26% +0.29%
- Complexity 9677 9738 +61
=============================================
Files 1158 1158
Lines 83987 84020 +33
Branches 10917 10923 +6
=============================================
+ Hits 36093 36353 +260
+ Misses 43399 43146 -253
- Partials 4495 4521 +26
```
| [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ocketmq/broker/processor/SendMessageProcessor.java](https://app.codecov.io/gh/apache/rocketmq/pull/7541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL1NlbmRNZXNzYWdlUHJvY2Vzc29yLmphdmE=) | `37.13% <100.00%> (+0.84%)` | :arrow_up: |
| [...rocketmq/common/message/MessageExtBrokerInner.java](https://app.codecov.io/gh/apache/rocketmq/pull/7541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vbWVzc2FnZS9NZXNzYWdlRXh0QnJva2VySW5uZXIuamF2YQ==) | `28.57% <100.00%> (-27.43%)` | :arrow_down: |
| [...pache/rocketmq/store/kv/CompactionPositionMgr.java](https://app.codecov.io/gh/apache/rocketmq/pull/7541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2t2L0NvbXBhY3Rpb25Qb3NpdGlvbk1nci5qYXZh) | `83.33% <100.00%> (ø)` | |
| [...in/java/org/apache/rocketmq/common/KeyBuilder.java](https://app.codecov.io/gh/apache/rocketmq/pull/7541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vS2V5QnVpbGRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...org/apache/rocketmq/common/utils/MessageUtils.java](https://app.codecov.io/gh/apache/rocketmq/pull/7541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vdXRpbHMvTWVzc2FnZVV0aWxzLmphdmE=) | `61.11% <88.00%> (+61.11%)` | :arrow_up: |
| [...org/apache/rocketmq/store/DefaultMessageStore.java](https://app.codecov.io/gh/apache/rocketmq/pull/7541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0RlZmF1bHRNZXNzYWdlU3RvcmUuamF2YQ==) | `46.85% <75.00%> (+0.21%)` | :arrow_up: |
| [.../org/apache/rocketmq/store/kv/CompactionStore.java](https://app.codecov.io/gh/apache/rocketmq/pull/7541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2t2L0NvbXBhY3Rpb25TdG9yZS5qYXZh) | `49.13% <64.28%> (+17.40%)` | :arrow_up: |
... and [38 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/7541/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in [Chrome](https://chrome.google.com/webstore/detail/codecov/gedikamndpbemklijjkncpnolildpbgo) or [Firefox](https://addons.mozilla.org/en-US/firefox/addon/codecov/) today!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #7540] Fix query offset of compaction topic [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7541:
URL: https://github.com/apache/rocketmq/pull/7541#issuecomment-3508988480
This PR was closed because it has been inactive for 3 days since being marked as stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org