[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #2714: xtensa/esp32: Add support to LWL

[GitBox <gi...@apache.org>]

Ouss4 commented on a change in pull request #2714:
URL: https://github.com/apache/incubator-nuttx/pull/2714#discussion_r559809304



##########
File path: arch/xtensa/src/common/xtensa_lwl_console.c
##########
@@ -0,0 +1,313 @@
+/****************************************************************************
+ *

Review comment:
       Add name of the file

##########
File path: arch/xtensa/Kconfig
##########
@@ -139,6 +139,19 @@ config XTENSA_IMEM_PROCFS
 	default n
 	depends on XTENSA_USE_SEPARATE_IMEM && !DISABLE_MOUNTPOINT && FS_PROCFS && FS_PROCFS_REGISTER
 
+config XTENSA_LWL_CONSOLE
+	bool "Lightweight Link Console Support"
+	default n
+	depends on DEV_CONSOLE && ARCH_CHIP_ESP32
+	---help---
+		Use the lightweight link console which provides console over a
+		debug channel by means of shared memory.  A terminal application
+		for openocd as the debugger is available in tools/ocdconsole.py.
+
+		Currently only available for ESP32 architectures, but easily
+		added to other Xtensa architectures be add up_low_console.c to

Review comment:
       ```suggestion
   		Currently only available for ESP32 architectures, but can easily be
   		added to other Xtensa architectures by adding xtensa_low_console.c to
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org