[GitHub] [pulsar] eolivelli commented on a diff in pull request #17308: [fix] Combination of autocreate + forced delete of partitioned topic with active consumer leaves topic metadata inconsistent.

[GitBox <gi...@apache.org>]

eolivelli commented on code in PR #17308:
URL: https://github.com/apache/pulsar/pull/17308#discussion_r956541403


##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ExclusiveProducerTest.java:
##########
@@ -331,7 +332,12 @@ public void topicDeleted(String ignored, boolean partitioned) throws Exception {
         p1.send("msg-1");
 
         if (partitioned) {
-            admin.topics().deletePartitionedTopic(topic, true);
+            try {
+                admin.topics().deletePartitionedTopic(topic, true);
+                fail("expected error because partitioned topic has active producer");
+            } catch (PulsarAdminException.ServerSideErrorException e) {

Review Comment:
   ServerSideError is not very user friendly.
   I would expect 'Conflict' or the same thing that happens when you do not use the 'force' option



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org