You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org> on 2019/04/30 06:00:22 UTC
[Impala-ASF-CR] IMPALA-8455: Gracefully handle failed loads in GET TABLES req
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13186
Change subject: IMPALA-8455: Gracefully handle failed loads in GET_TABLES req
......................................................................
IMPALA-8455: Gracefully handle failed loads in GET_TABLES req
Some HS2 clients (like Hue) rely on the GET_TABLES request to
populate table meta information. In local catalog mode, for any
table loading failures, this call throws a cryptic exception
that the callers do not expect.
The original ImpaladCatalog implementation gracefully handled this
by silently ignoring such tables. This patch replicates that
behavior in LocalCatalog mode.
Testing: Added a unit test that consistently fails without the patch.
Change-Id: I89cc2c585aa83a9aea5343f0d0383ba72bafd618
---
M fe/src/main/java/org/apache/impala/catalog/FeCatalog.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java
M fe/src/main/java/org/apache/impala/service/MetadataOp.java
M fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java
4 files changed, 42 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/13186/1
--
To view, visit http://gerrit.cloudera.org:8080/13186
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I89cc2c585aa83a9aea5343f0d0383ba72bafd618
Gerrit-Change-Number: 13186
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
[Impala-ASF-CR] IMPALA-8455: Gracefully handle failed loads in GET TABLES req
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13186 )
Change subject: IMPALA-8455: Gracefully handle failed loads in GET_TABLES req
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13186
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89cc2c585aa83a9aea5343f0d0383ba72bafd618
Gerrit-Change-Number: 13186
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 30 Apr 2019 17:03:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8455: Gracefully handle failed loads in GET TABLES req
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Hello Todd Lipcon, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13186
to look at the new patch set (#2).
Change subject: IMPALA-8455: Gracefully handle failed loads in GET_TABLES req
......................................................................
IMPALA-8455: Gracefully handle failed loads in GET_TABLES req
Some HS2 clients (like Hue) rely on the GET_TABLES request to
populate table meta information. In local catalog mode, for any
table loading failures, this call throws a cryptic exception
that the callers do not expect.
The original ImpaladCatalog implementation gracefully handled this
by silently ignoring such tables. This patch replicates that
behavior in LocalCatalog mode.
Testing: Added a unit test that consistently fails without the patch.
Change-Id: I89cc2c585aa83a9aea5343f0d0383ba72bafd618
---
M fe/src/main/java/org/apache/impala/catalog/FeCatalog.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java
M fe/src/main/java/org/apache/impala/service/MetadataOp.java
M fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java
4 files changed, 42 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/13186/2
--
To view, visit http://gerrit.cloudera.org:8080/13186
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I89cc2c585aa83a9aea5343f0d0383ba72bafd618
Gerrit-Change-Number: 13186
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[Impala-ASF-CR] IMPALA-8455: Gracefully handle failed loads in GET TABLES req
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13186 )
Change subject: IMPALA-8455: Gracefully handle failed loads in GET_TABLES req
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4123/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13186
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89cc2c585aa83a9aea5343f0d0383ba72bafd618
Gerrit-Change-Number: 13186
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 30 Apr 2019 18:08:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8455: Gracefully handle failed loads in GET TABLES req
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13186 )
Change subject: IMPALA-8455: Gracefully handle failed loads in GET_TABLES req
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13186
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89cc2c585aa83a9aea5343f0d0383ba72bafd618
Gerrit-Change-Number: 13186
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 30 Apr 2019 23:46:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8455: Gracefully handle failed loads in GET TABLES req
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13186 )
Change subject: IMPALA-8455: Gracefully handle failed loads in GET_TABLES req
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/2995/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/13186
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89cc2c585aa83a9aea5343f0d0383ba72bafd618
Gerrit-Change-Number: 13186
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 30 Apr 2019 06:57:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8455: Gracefully handle failed loads in GET TABLES req
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13186 )
Change subject: IMPALA-8455: Gracefully handle failed loads in GET_TABLES req
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3008/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13186
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89cc2c585aa83a9aea5343f0d0383ba72bafd618
Gerrit-Change-Number: 13186
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 30 Apr 2019 18:56:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8455: Gracefully handle failed loads in GET TABLES req
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13186 )
Change subject: IMPALA-8455: Gracefully handle failed loads in GET_TABLES req
......................................................................
Patch Set 2: Code-Review+2
Rebased and fixed a trivial conflict. Carrying +2.
--
To view, visit http://gerrit.cloudera.org:8080/13186
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89cc2c585aa83a9aea5343f0d0383ba72bafd618
Gerrit-Change-Number: 13186
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 30 Apr 2019 18:07:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8455: Gracefully handle failed loads in GET TABLES req
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13186 )
Change subject: IMPALA-8455: Gracefully handle failed loads in GET_TABLES req
......................................................................
IMPALA-8455: Gracefully handle failed loads in GET_TABLES req
Some HS2 clients (like Hue) rely on the GET_TABLES request to
populate table meta information. In local catalog mode, for any
table loading failures, this call throws a cryptic exception
that the callers do not expect.
The original ImpaladCatalog implementation gracefully handled this
by silently ignoring such tables. This patch replicates that
behavior in LocalCatalog mode.
Testing: Added a unit test that consistently fails without the patch.
Change-Id: I89cc2c585aa83a9aea5343f0d0383ba72bafd618
Reviewed-on: http://gerrit.cloudera.org:8080/13186
Reviewed-by: Bharath Vissapragada <bh...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/catalog/FeCatalog.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java
M fe/src/main/java/org/apache/impala/service/MetadataOp.java
M fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java
4 files changed, 42 insertions(+), 3 deletions(-)
Approvals:
Bharath Vissapragada: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13186
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I89cc2c585aa83a9aea5343f0d0383ba72bafd618
Gerrit-Change-Number: 13186
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>