You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/02 16:36:04 UTC
[GitHub] [pulsar] liangyuanpeng opened a new pull request, #15907: [feature][functions][WIP]Add auth params for function go
liangyuanpeng opened a new pull request, #15907:
URL: https://github.com/apache/pulsar/pull/15907
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
*(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
Fixes #<xyz>
*(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)*
Master Issue: #<xyz>
### Motivation
Support auth for function-go.
### Modifications
Actually, i finished the feature and working for the PR.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [ ] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liangyuanpeng commented on pull request #15907: [feature][functions]Support auth for function go
Posted by GitBox <gi...@apache.org>.
liangyuanpeng commented on PR #15907:
URL: https://github.com/apache/pulsar/pull/15907#issuecomment-1153134365
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liangyuanpeng commented on pull request #15907: [feature][functions]Support auth for function go
Posted by GitBox <gi...@apache.org>.
liangyuanpeng commented on PR #15907:
URL: https://github.com/apache/pulsar/pull/15907#issuecomment-1257176385
/ping @nlu90 @nicoloboschi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #15907: [feature][functions]Support auth for function go
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15907:
URL: https://github.com/apache/pulsar/pull/15907#issuecomment-1151168086
@liangyuanpeng:Thanks for providing doc info!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #15907: [feature][functions]Support auth for function go
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15907:
URL: https://github.com/apache/pulsar/pull/15907#issuecomment-1292875419
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liangyuanpeng commented on pull request #15907: [feature][functions]Support auth for function go
Posted by GitBox <gi...@apache.org>.
liangyuanpeng commented on PR #15907:
URL: https://github.com/apache/pulsar/pull/15907#issuecomment-1257165881
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liangyuanpeng commented on pull request #15907: [feature][functions]Support auth for function go
Posted by GitBox <gi...@apache.org>.
liangyuanpeng commented on PR #15907:
URL: https://github.com/apache/pulsar/pull/15907#issuecomment-1257156937
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #15907: [feature][functions]Support auth for function go
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on code in PR #15907:
URL: https://github.com/apache/pulsar/pull/15907#discussion_r1023526177
##########
pulsar-function-go/conf/conf.go:
##########
@@ -77,6 +77,9 @@ type Conf struct {
UserConfig string `json:"userConfig" yaml:"userConfig"`
//metrics config
MetricsPort int `json:"metricsPort" yaml:"metricsPort"`
+
+ ClientAuthPlugin string `json:"clientAuthPlugin" yaml:"clientAuthPlugin"`
+ ClientAuthParams string `json:"clientAuthParams" yaml:"clientAuthParams"`
Review Comment:
Nit: is there a reason this uses `Auth` instead of `Authentication` for these field names? I think it is valuable to have identical field names across languages, when possible, to make it easy to transition between clients. That won't work for python, which uses snake casing, but I still think it could be helpful here. What is your perspective @liangyuanpeng?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #15907: [feature][functions]Support auth for function go
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on code in PR #15907:
URL: https://github.com/apache/pulsar/pull/15907#discussion_r1066411080
##########
pulsar-function-go/conf/conf.go:
##########
@@ -77,6 +77,9 @@ type Conf struct {
UserConfig string `json:"userConfig" yaml:"userConfig"`
//metrics config
MetricsPort int `json:"metricsPort" yaml:"metricsPort"`
+
+ ClientAuthPlugin string `json:"clientAuthPlugin" yaml:"clientAuthPlugin"`
+ ClientAuthParams string `json:"clientAuthParams" yaml:"clientAuthParams"`
Review Comment:
The convention for functions is to use `Authentication`:
https://github.com/apache/pulsar/blob/82237d3684fe506bcb6426b3b23f413422e6e4fb/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/AuthenticationConfig.java#L30-L31
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #15907: [feature][functions][WIP]Add auth params for function go
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15907:
URL: https://github.com/apache/pulsar/pull/15907#issuecomment-1145074167
@liangyuanpeng:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nlu90 commented on a diff in pull request #15907: [feature][functions]Support auth for function go
Posted by GitBox <gi...@apache.org>.
nlu90 commented on code in PR #15907:
URL: https://github.com/apache/pulsar/pull/15907#discussion_r1081625569
##########
pulsar-function-go/conf/conf.go:
##########
@@ -77,6 +77,9 @@ type Conf struct {
UserConfig string `json:"userConfig" yaml:"userConfig"`
//metrics config
MetricsPort int `json:"metricsPort" yaml:"metricsPort"`
+
+ ClientAuthPlugin string `json:"clientAuthPlugin" yaml:"clientAuthPlugin"`
+ ClientAuthParams string `json:"clientAuthParams" yaml:"clientAuthParams"`
Review Comment:
The convention diverged.
I'm fine with either. Let's conform to one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liangyuanpeng commented on pull request #15907: [feature][functions]Support auth for function go
Posted by GitBox <gi...@apache.org>.
liangyuanpeng commented on PR #15907:
URL: https://github.com/apache/pulsar/pull/15907#issuecomment-1152493537
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #15907: [feature][functions]Support auth for function go
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15907:
URL: https://github.com/apache/pulsar/pull/15907#issuecomment-1211489683
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nlu90 commented on a diff in pull request #15907: [feature][functions]Support auth for function go
Posted by GitBox <gi...@apache.org>.
nlu90 commented on code in PR #15907:
URL: https://github.com/apache/pulsar/pull/15907#discussion_r1066271927
##########
pulsar-function-go/conf/conf.go:
##########
@@ -77,6 +77,9 @@ type Conf struct {
UserConfig string `json:"userConfig" yaml:"userConfig"`
//metrics config
MetricsPort int `json:"metricsPort" yaml:"metricsPort"`
+
+ ClientAuthPlugin string `json:"clientAuthPlugin" yaml:"clientAuthPlugin"`
+ ClientAuthParams string `json:"clientAuthParams" yaml:"clientAuthParams"`
Review Comment:
It's kind of a convention across different language runtimes:
https://github.com/apache/pulsar/search?q=ClientAuthPlugin&type=
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #15907: [feature][functions]Support auth for function go
Posted by GitBox <gi...@apache.org>.
eolivelli commented on PR #15907:
URL: https://github.com/apache/pulsar/pull/15907#issuecomment-1257533498
@zzzming thanks for your review.
@liangyuanpeng please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org