You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/01 10:46:06 UTC
[GitHub] [spark] LuciferYang opened a new pull request #31416: [SPARK-34310][CORE][SQL] Replaces map and flatten with flatMap
LuciferYang opened a new pull request #31416:
URL: https://github.com/apache/spark/pull/31416
### What changes were proposed in this pull request?
Replaces `collection.map(f1).flatten(f2)` with `collection.flatMap` if possible. it's semantically consistent, but looks simpler.
### Why are the changes needed?
Code Simpilefications.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass the Jenkins or GitHub Action
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #31416: [SPARK-34310][CORE][SQL] Replaces map and flatten with flatMap
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #31416:
URL: https://github.com/apache/spark/pull/31416#issuecomment-771310680
thx @srowen @HyukjinKwon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31416: [SPARK-34310][CORE][SQL] Replaces map and flatten with flatMap
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31416:
URL: https://github.com/apache/spark/pull/31416#issuecomment-770870443
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134732/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31416: [SPARK-34310][CORE][SQL] Replaces map and flatten with flatMap
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31416:
URL: https://github.com/apache/spark/pull/31416#issuecomment-770832838
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39318/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #31416: [SPARK-34310][CORE][SQL] Replaces map and flatten with flatMap
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #31416:
URL: https://github.com/apache/spark/pull/31416#issuecomment-771255976
OK, eh I didn't back port the merge to 3.1. The PRs back port to 3.0 / 2.4. It'd be have to backported to 3.1 manually first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31416: [SPARK-34310][CORE][SQL] Replaces map and flatten with flatMap
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31416:
URL: https://github.com/apache/spark/pull/31416#issuecomment-771254590
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31416: [SPARK-34310][CORE][SQL] Replaces map and flatten with flatMap
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31416:
URL: https://github.com/apache/spark/pull/31416#issuecomment-770792285
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39318/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #31416: [SPARK-34310][CORE][SQL] Replaces map and flatten with flatMap
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #31416:
URL: https://github.com/apache/spark/pull/31416
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #31416: [SPARK-34310][CORE][SQL] Replaces map and flatten with flatMap
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #31416:
URL: https://github.com/apache/spark/pull/31416#issuecomment-771310680
thx @dongjoon-hyun @HyukjinKwon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31416: [SPARK-34310][CORE][SQL] Replaces map and flatten with flatMap
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31416:
URL: https://github.com/apache/spark/pull/31416#issuecomment-770854169
**[Test build #134732 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134732/testReport)** for PR 31416 at commit [`886c2b9`](https://github.com/apache/spark/commit/886c2b938d034a6542d11cbff8cc28831a61dddc).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31416: [SPARK-34310][CORE][SQL] Replaces map and flatten with flatMap
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31416:
URL: https://github.com/apache/spark/pull/31416#issuecomment-771255480
Let me just port it back for now, @srowen. It shouldn't affect anything in the codes anyway ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #31416: [SPARK-34310][CORE][SQL] Replaces map and flatten with flatMap
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #31416:
URL: https://github.com/apache/spark/pull/31416#issuecomment-770899470
> The change is fine, but I don't think we need to back-port this.
Just to reduce the possibility of conflict, If unnecessary, I will close the other prs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31416: [SPARK-34310][CORE][SQL] Replaces map and flatten with flatMap
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31416:
URL: https://github.com/apache/spark/pull/31416#issuecomment-771256210
Done :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31416: [SPARK-34310][CORE][SQL] Replaces map and flatten with flatMap
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31416:
URL: https://github.com/apache/spark/pull/31416#issuecomment-770808212
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39318/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31416: [SPARK-34310][CORE][SQL] Replaces map and flatten with flatMap
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31416:
URL: https://github.com/apache/spark/pull/31416#issuecomment-770772162
**[Test build #134732 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134732/testReport)** for PR 31416 at commit [`886c2b9`](https://github.com/apache/spark/commit/886c2b938d034a6542d11cbff8cc28831a61dddc).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31416: [SPARK-34310][CORE][SQL] Replaces map and flatten with flatMap
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31416:
URL: https://github.com/apache/spark/pull/31416#issuecomment-770870443
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134732/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31416: [SPARK-34310][CORE][SQL] Replaces map and flatten with flatMap
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31416:
URL: https://github.com/apache/spark/pull/31416#issuecomment-770772162
**[Test build #134732 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134732/testReport)** for PR 31416 at commit [`886c2b9`](https://github.com/apache/spark/commit/886c2b938d034a6542d11cbff8cc28831a61dddc).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #31416: [SPARK-34310][CORE][SQL] Replaces map and flatten with flatMap
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #31416:
URL: https://github.com/apache/spark/pull/31416#issuecomment-771310680
thx @srowen @HyukjinKwon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #31416: [SPARK-34310][CORE][SQL] Replaces map and flatten with flatMap
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #31416:
URL: https://github.com/apache/spark/pull/31416#issuecomment-771255976
OK, eh I didn't back port the merge to 3.1. The PRs back port to 3.0 / 2.4. It'd be have to backported to 3.1 manually first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31416: [SPARK-34310][CORE][SQL] Replaces map and flatten with flatMap
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31416:
URL: https://github.com/apache/spark/pull/31416#issuecomment-770804961
The fix is trivial and it looks fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31416: [SPARK-34310][CORE][SQL] Replaces map and flatten with flatMap
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31416:
URL: https://github.com/apache/spark/pull/31416#issuecomment-771254590
Yeah, technically it's not something we should port back since it's neither a bug fix nor an improvement. I just asked him to backport just to reduce a conflict when we backport something. This change is pretty safe and virtually noop before/after anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #31416: [SPARK-34310][CORE][SQL] Replaces map and flatten with flatMap
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #31416:
URL: https://github.com/apache/spark/pull/31416#issuecomment-771310680
thx @dongjoon-hyun @HyukjinKwon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #31416: [SPARK-34310][CORE][SQL] Replaces map and flatten with flatMap
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #31416:
URL: https://github.com/apache/spark/pull/31416#issuecomment-770891276
The change is fine, but I don't think we need to back-port this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31416: [SPARK-34310][CORE][SQL] Replaces map and flatten with flatMap
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31416:
URL: https://github.com/apache/spark/pull/31416#issuecomment-770832838
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39318/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #31416: [SPARK-34310][CORE][SQL] Replaces map and flatten with flatMap
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #31416:
URL: https://github.com/apache/spark/pull/31416#issuecomment-770762871
For other branch:
- branch-3.0: https://github.com/apache/spark/pull/31418
- branch-2.4: https://github.com/apache/spark/pull/31417
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org