You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by li...@apache.org on 2013/11/28 19:13:22 UTC

svn commit: r1546426 - /hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java

Author: liyin
Date: Thu Nov 28 18:13:21 2013
New Revision: 1546426

URL: http://svn.apache.org/r1546426
Log:
[master] Reduce log spam upon Scanner close

Author: arjen

Summary: D971692 makes a log line being printed upon closing a Scanner (P3083477). This seems rather excessive and it generates quite a bit of log under load.

Test Plan: Compiled and deployed a jar on hbase474.frc3. The line went away.

Reviewers: liyintang, aaiyer, manukranthk

Reviewed By: liyintang

CC: hbase-eng@

Differential Revision: https://phabricator.fb.com/D1046339

Modified:
    hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java

Modified: hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java?rev=1546426&r1=1546425&r2=1546426&view=diff
==============================================================================
--- hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java (original)
+++ hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java Thu Nov 28 18:13:21 2013
@@ -863,7 +863,9 @@ public class HFileReaderV2 extends Abstr
      */
     @Override
     public void close() {
-      LOG.info("Closing HFileScanner for file" + hfileReaderV2.getName());
+      if (LOG.isTraceEnabled()) {
+        LOG.trace("Closing HFileScanner for file " + hfileReaderV2.getName());
+      }
       if (preloadBlocks) {
         blockManager.close();
       }