svn commit: r924169 - /qpid/trunk/qpid/cpp/src/qpid/client/TCPConnector.cpp

[mg...@apache.org]

Author: mgoulish
Date: Wed Mar 17 05:52:12 2010
New Revision: 924169

URL: http://svn.apache.org/viewvc?rev=924169&view=rev
Log:
workaround for BZ 570168 ( see comment in code )

Modified:
    qpid/trunk/qpid/cpp/src/qpid/client/TCPConnector.cpp

Modified: qpid/trunk/qpid/cpp/src/qpid/client/TCPConnector.cpp
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/client/TCPConnector.cpp?rev=924169&r1=924168&r2=924169&view=diff
==============================================================================
--- qpid/trunk/qpid/cpp/src/qpid/client/TCPConnector.cpp (original)
+++ qpid/trunk/qpid/cpp/src/qpid/client/TCPConnector.cpp Wed Mar 17 05:52:12 2010
@@ -199,8 +199,19 @@ void TCPConnector::send(AMQFrame& frame)
     } else {
         notifyWrite = (currentSize >= maxFrameSize);
     }
-    }
+    /*
+      NOTE: Moving the following line into this mutex block
+            is a workaround for BZ 570168, in which the test
+            testConcurrentSenders causes a hang about 1.5%
+            of the time.  ( To see the hang much more frequently
+            leave this line out of the mutex block, and put a 
+            small usleep just before it.)
+
+            TODO mgoulish - fix the underlying cause and then
+                            move this call back outside the mutex.
+    */
     if (notifyWrite && !closed) aio->notifyPendingWrite();
+    }
 }
 
 void TCPConnector::handleClosed() {



---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:commits-subscribe@qpid.apache.org