You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "HappenLee (via GitHub)" <gi...@apache.org> on 2024/09/18 09:33:04 UTC

[PR] [Refactor](scan) remove unless code in BE and FE [doris]

HappenLee opened a new pull request, #40927:
URL: https://github.com/apache/doris/pull/40927

   ## Proposed changes
   
   1. change error comment of FE
   2. delete the unless code of BE/FE
   
   
   <!--Describe your changes.-->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Refactor](scan) remove unless code in BE and FE [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40927:
URL: https://github.com/apache/doris/pull/40927#issuecomment-2357968923

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
   See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Refactor](scan) remove unless code in BE and FE [doris]

Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on PR #40927:
URL: https://github.com/apache/doris/pull/40927#issuecomment-2357969188

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Refactor](scan) remove unless code in BE and FE [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40927:
URL: https://github.com/apache/doris/pull/40927#issuecomment-2358020761

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 41438 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 8070ca09e002888a5b300a378c0621e72233bce4, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17981	7408	7339	7339
   q2	2505	161	156	156
   q3	10572	1139	1141	1139
   q4	10222	793	751	751
   q5	7726	3078	3047	3047
   q6	231	158	147	147
   q7	1011	633	604	604
   q8	9431	1991	2048	1991
   q9	6801	6379	6377	6377
   q10	7008	2287	2274	2274
   q11	441	247	241	241
   q12	412	209	214	209
   q13	17776	2985	2994	2985
   q14	256	221	237	221
   q15	563	532	528	528
   q16	689	611	612	611
   q17	957	794	810	794
   q18	7205	6586	6573	6573
   q19	1409	1022	1075	1022
   q20	588	291	279	279
   q21	3940	3257	3174	3174
   q22	1105	976	1019	976
   Total cold run time: 108829 ms
   Total hot run time: 41438 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	7246	7232	7257	7232
   q2	329	234	223	223
   q3	2907	2775	2778	2775
   q4	1891	1668	1686	1668
   q5	5363	5409	5370	5370
   q6	225	141	140	140
   q7	2103	1747	1709	1709
   q8	3153	3313	3272	3272
   q9	8395	8334	8364	8334
   q10	3383	3334	3332	3332
   q11	579	470	480	470
   q12	790	566	575	566
   q13	8156	3004	3009	3004
   q14	302	257	266	257
   q15	560	514	513	513
   q16	714	665	676	665
   q17	1751	1572	1555	1555
   q18	7804	7409	7429	7409
   q19	1664	1548	1473	1473
   q20	2030	1794	1802	1794
   q21	5303	4972	5105	4972
   q22	1119	1023	1022	1022
   Total cold run time: 65767 ms
   Total hot run time: 57755 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Refactor](scan) remove unless code in BE and FE [doris]

Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee merged PR #40927:
URL: https://github.com/apache/doris/pull/40927


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Refactor](scan) remove unless code in BE and FE [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40927:
URL: https://github.com/apache/doris/pull/40927#issuecomment-2358046003

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 194093 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 8070ca09e002888a5b300a378c0621e72233bce4, data reload: false
   
   query1	969	364	355	355
   query2	6525	2001	1965	1965
   query3	6701	213	224	213
   query4	34189	23368	23388	23368
   query5	4320	493	494	493
   query6	256	170	175	170
   query7	4634	294	303	294
   query8	286	228	223	223
   query9	9376	2663	2642	2642
   query10	481	291	284	284
   query11	18150	15301	15310	15301
   query12	161	97	99	97
   query13	1625	430	399	399
   query14	10625	7335	6736	6736
   query15	277	166	180	166
   query16	8050	468	452	452
   query17	1624	581	559	559
   query18	2149	305	307	305
   query19	362	152	152	152
   query20	118	109	110	109
   query21	217	103	104	103
   query22	4389	4203	4328	4203
   query23	34897	34184	33914	33914
   query24	11143	2975	2866	2866
   query25	658	403	410	403
   query26	1382	162	166	162
   query27	2866	281	296	281
   query28	7932	2452	2449	2449
   query29	900	423	441	423
   query30	329	158	171	158
   query31	1017	745	827	745
   query32	105	56	56	56
   query33	766	305	297	297
   query34	956	496	496	496
   query35	867	748	730	730
   query36	1103	904	949	904
   query37	158	99	87	87
   query38	4078	3951	3867	3867
   query39	1457	1388	1406	1388
   query40	286	98	98	98
   query41	52	50	49	49
   query42	115	100	98	98
   query43	518	470	480	470
   query44	1287	834	798	798
   query45	194	168	168	168
   query46	1133	747	771	747
   query47	1879	1803	1817	1803
   query48	454	355	380	355
   query49	1184	418	410	410
   query50	829	404	409	404
   query51	7048	7073	6941	6941
   query52	101	88	89	88
   query53	252	184	187	184
   query54	1277	465	464	464
   query55	86	73	79	73
   query56	279	267	269	267
   query57	1226	1100	1081	1081
   query58	256	233	241	233
   query59	3174	2907	3075	2907
   query60	324	283	278	278
   query61	230	105	109	105
   query62	889	647	655	647
   query63	208	187	183	183
   query64	5328	644	631	631
   query65	3324	3168	3185	3168
   query66	1419	305	307	305
   query67	16363	15537	15568	15537
   query68	3290	852	844	844
   query69	443	343	346	343
   query70	1219	1112	1181	1112
   query71	346	334	329	329
   query72	6105	3394	3443	3394
   query73	587	573	586	573
   query74	9672	8945	9048	8945
   query75	3014	2843	2876	2843
   query76	1950	866	853	853
   query77	391	361	366	361
   query78	9552	9496	9274	9274
   query79	913	881	866	866
   query80	653	597	576	576
   query81	451	251	248	248
   query82	235	234	239	234
   query83	157	162	157	157
   query84	238	110	96	96
   query85	686	370	353	353
   query86	313	314	298	298
   query87	4470	4359	4331	4331
   query88	4762	4082	4083	4082
   query89	389	357	364	357
   query90	1448	320	324	320
   query91	171	165	185	165
   query92	83	72	72	72
   query93	902	903	899	899
   query94	564	356	358	356
   query95	426	412	412	412
   query96	491	496	491	491
   query97	3151	3118	3135	3118
   query98	235	224	217	217
   query99	1400	1304	1267	1267
   Total cold run time: 294520 ms
   Total hot run time: 194093 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Refactor](scan) remove unless code in BE and FE [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40927:
URL: https://github.com/apache/doris/pull/40927#issuecomment-2358065342

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 33.52 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 8070ca09e002888a5b300a378c0621e72233bce4, data reload: false
   
   query1	0.04	0.04	0.04
   query2	0.06	0.03	0.03
   query3	0.23	0.06	0.06
   query4	1.66	0.10	0.10
   query5	0.52	0.51	0.50
   query6	1.12	0.72	0.73
   query7	0.02	0.02	0.02
   query8	0.04	0.03	0.04
   query9	0.56	0.50	0.50
   query10	0.54	0.56	0.57
   query11	0.14	0.11	0.11
   query12	0.13	0.10	0.11
   query13	0.62	0.60	0.59
   query14	2.96	3.03	3.00
   query15	0.90	0.82	0.82
   query16	0.40	0.39	0.41
   query17	1.06	1.06	1.04
   query18	0.22	0.20	0.21
   query19	1.81	1.87	1.99
   query20	0.01	0.01	0.01
   query21	15.35	0.60	0.60
   query22	2.29	2.72	2.27
   query23	17.24	1.07	0.81
   query24	2.74	1.21	1.29
   query25	0.28	0.17	0.08
   query26	0.44	0.14	0.14
   query27	0.04	0.05	0.04
   query28	10.41	1.09	1.07
   query29	12.55	3.26	3.26
   query30	0.25	0.06	0.06
   query31	2.88	0.38	0.38
   query32	3.27	0.46	0.46
   query33	2.96	2.99	2.97
   query34	16.85	4.34	4.41
   query35	4.51	4.36	4.39
   query36	0.66	0.50	0.48
   query37	0.08	0.06	0.06
   query38	0.04	0.03	0.04
   query39	0.03	0.02	0.02
   query40	0.17	0.12	0.12
   query41	0.07	0.03	0.02
   query42	0.03	0.02	0.02
   query43	0.04	0.03	0.03
   Total cold run time: 106.22 s
   Total hot run time: 33.52 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Refactor](scan) remove unless code in BE and FE [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40927:
URL: https://github.com/apache/doris/pull/40927#issuecomment-2358036522

   TeamCity be ut coverage result:
    Function Coverage: 37.33% (9582/25671) 
    Line Coverage: 28.71% (79203/275861)
    Region Coverage: 28.20% (41029/145497)
    Branch Coverage: 24.81% (20904/84242)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/8070ca09e002888a5b300a378c0621e72233bce4_8070ca09e002888a5b300a378c0621e72233bce4/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Refactor](scan) remove unless code in BE and FE [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40927:
URL: https://github.com/apache/doris/pull/40927#issuecomment-2358025461

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Refactor](scan) remove unless code in BE and FE [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40927:
URL: https://github.com/apache/doris/pull/40927#issuecomment-2358025548

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org