You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/04/24 12:32:25 UTC
[GitHub] [incubator-kyuubi] wForget commented on a diff in pull request #2462: [KYUUBI #2461] Use the original host argument
wForget commented on code in PR #2462:
URL: https://github.com/apache/incubator-kyuubi/pull/2462#discussion_r857119434
##########
kyuubi-ctl/src/main/scala/org/apache/kyuubi/ctl/ServiceControlCliArguments.scala:
##########
@@ -249,7 +249,8 @@ class ServiceControlCliArguments(args: Seq[String], env: Map[String, String] = s
}
try {
- cliArgs = cliArgs.copy(host = InetAddress.getByName(cliArgs.host).getCanonicalHostName)
+ InetAddress.getByName(cliArgs.host)
Review Comment:
> Because `kyuubi.frontend.connection.url.use.hostname` is configured to determine whether the node registered to zookeeper is hostname or ip, would it be better to use the original value passed in with `--host` here?
When we configure `kyuubi.frontend.thrift.binary.bind.host`, the `kyuubi.frontend.connection.url.use.hostname` config does not seem to take effect, we use the original host argument will be more flexible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org