[GitHub] [lucene] jpountz commented on pull request #12135: Avoid duplicate sorting and prefix-encoding in KeywordField#newSetQuery

["jpountz (via GitHub)" <gi...@apache.org>]

jpountz commented on PR #12135:
URL: https://github.com/apache/lucene/pull/12135#issuecomment-1423019557

   Thanks for looking into this @gsmiller I agree we should avoid computing the prefix terms twice. I like the approach of having a private ctor that takes prefix coded terms and using it from the `KeywordField#newSetQuery` method. As far as streams are concerned, Uwe's arguments are appealing but I have a (subjective) distaste of the Stream API which makes me prefer avoiding to use them in our public APIs. :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org