[GitHub] [incubator-druid] FaxianZhao commented on a change in pull request #8598: bug fix for lookup leak when we remove the last lookup from lookup tier

[GitBox <gi...@apache.org>]

FaxianZhao commented on a change in pull request #8598: bug fix for lookup leak when we remove the last lookup from lookup tier
URL: https://github.com/apache/incubator-druid/pull/8598#discussion_r328887741
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/server/lookup/cache/LookupCoordinatorManager.java
 ##########
 @@ -557,16 +557,16 @@ void lookupManagementLoop()
 
     try {
       List<ListenableFuture<Map.Entry>> futures = new ArrayList<>();
-      for (Map.Entry<String, Map<String, LookupExtractorFactoryMapContainer>> tierEntry : allLookupTiers.entrySet()) {
+      for (String tier : lookupNodeDiscovery.getAllTiers()) {
 
 Review comment:
   > can you merge [FaxianZhao#1](https://github.com/FaxianZhao/incubator-druid/pull/1) to add another block to note lookups that will never be loaded?
   
   Good idea.
   But for the users who enable 'druid.lookup.lookupTierIsDatasource', will this warning confuse them?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org