[jira] [Commented] (BOOKKEEPER-1063) Use executure.execute() instead of submit() to avoid creation of unused FutureTask

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-1063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005524#comment-16005524 ] 

ASF GitHub Bot commented on BOOKKEEPER-1063:
--------------------------------------------

GitHub user merlimat opened a pull request:

    https://github.com/apache/bookkeeper/pull/150

    BOOKKEEPER-1063: Use executure.execute() instead of submit() to avoid…

    … creation of unused FutureTask
    
    When submitting tasks to an executor, if the `FutureTask` object is not being used we should use `execute()` instead of `submit()` in order to avoid the task object allocation.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/merlimat/bookkeeper executor-execute

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bookkeeper/pull/150.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #150
    
----
commit e29b5078dc40e32965d22620734118b7e1b713f5
Author: Matteo Merli <mm...@yahoo-inc.com>
Date:   2015-07-02T22:26:18Z

    BOOKKEEPER-1063: Use executure.execute() instead of submit() to avoid creation of unused FutureTask

----


> Use executure.execute() instead of submit() to avoid creation of unused FutureTask
> ----------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-1063
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1063
>             Project: Bookkeeper
>          Issue Type: Improvement
>            Reporter: Matteo Merli
>            Assignee: Matteo Merli
>            Priority: Minor
>             Fix For: 4.5.0
>
>
> When submitting tasks to an executor, if the {{FutureTask}} object is not being used we should use {{execute()}} instead of {{submit()}} in order to avoid the task object allocation.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)