You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/22 04:34:38 UTC
[GitHub] [incubator-superset] nytai opened a new pull request #10994: chore: reduce number of error logs
nytai opened a new pull request #10994:
URL: https://github.com/apache/incubator-superset/pull/10994
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on a change in pull request #10994: chore: downgrade expected exception from error to info
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #10994:
URL: https://github.com/apache/incubator-superset/pull/10994#discussion_r492472899
##########
File path: superset/datasets/dao.py
##########
@@ -79,7 +79,7 @@ def validate_table_exists(database: Database, table_name: str, schema: str) -> b
database.get_table(table_name, schema=schema)
return True
except SQLAlchemyError as ex: # pragma: no cover
- logger.error("Got an error %s validating table: %s", str(ex), table_name)
+ logger.info("Got an error %s validating table: %s", str(ex), table_name)
Review comment:
since validation is expected to fail sometimes, it seems appropriate to log this a info instead of error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #10994: chore: downgrade expected exception from error to info
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #10994:
URL: https://github.com/apache/incubator-superset/pull/10994#discussion_r492496630
##########
File path: superset/datasets/dao.py
##########
@@ -79,7 +79,7 @@ def validate_table_exists(database: Database, table_name: str, schema: str) -> b
database.get_table(table_name, schema=schema)
return True
except SQLAlchemyError as ex: # pragma: no cover
- logger.error("Got an error %s validating table: %s", str(ex), table_name)
+ logger.info("Got an error %s validating table: %s", str(ex), table_name)
Review comment:
warn?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on a change in pull request #10994: chore: downgrade expected exception from error to info
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #10994:
URL: https://github.com/apache/incubator-superset/pull/10994#discussion_r492472899
##########
File path: superset/datasets/dao.py
##########
@@ -79,7 +79,7 @@ def validate_table_exists(database: Database, table_name: str, schema: str) -> b
database.get_table(table_name, schema=schema)
return True
except SQLAlchemyError as ex: # pragma: no cover
- logger.error("Got an error %s validating table: %s", str(ex), table_name)
+ logger.info("Got an error %s validating table: %s", str(ex), table_name)
Review comment:
since validation is expected to fail sometimes, it seems appropriate to log this a info instead of error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #10994: chore: downgrade expected exception from error to info
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #10994:
URL: https://github.com/apache/incubator-superset/pull/10994#discussion_r492496630
##########
File path: superset/datasets/dao.py
##########
@@ -79,7 +79,7 @@ def validate_table_exists(database: Database, table_name: str, schema: str) -> b
database.get_table(table_name, schema=schema)
return True
except SQLAlchemyError as ex: # pragma: no cover
- logger.error("Got an error %s validating table: %s", str(ex), table_name)
+ logger.info("Got an error %s validating table: %s", str(ex), table_name)
Review comment:
warn?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar merged pull request #10994: chore: downgrade expected exception from error to info
Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #10994:
URL: https://github.com/apache/incubator-superset/pull/10994
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org