[GitHub] [spark] HeartSaVioR commented on a diff in pull request #42716: [SPARK-45002][SS] Avoid uncaught exception from state store maintenance task thread on error to prevent executor being killed

["HeartSaVioR (via GitHub)" <gi...@apache.org>]

HeartSaVioR commented on code in PR #42716:
URL: https://github.com/apache/spark/pull/42716#discussion_r1308257194


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala:
##########
@@ -1373,6 +1386,12 @@ abstract class StateStoreSuiteBase[ProviderClass <: StateStoreProvider]
           eventually(timeout(30.seconds)) {
             assert(!StateStore.isMaintenanceRunning)
           }
+

Review Comment:
   For a future-proof, might be better to reset the value of `FakeStateStoreProviderWithMaintenanceError.errorOnMaintenance` at the earlier of testing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org