You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/02 07:18:56 UTC

[GitHub] [kafka] showuon opened a new pull request #8777: KAFKA-10082: Fix the failed testMultiConsumerStickyAssignment

showuon opened a new pull request #8777:
URL: https://github.com/apache/kafka/pull/8777

Fix the failed `testMultiConsumerStickyAssignment` by modify the logic error in `allSubscriptionsEqual` method. We will create the `consumerToOwnedPartitions` to keep the set of previously owned partitions encoded in the Subscription. It's our basis to do the reassignment. In the `allSubscriptionsEqual`, we'll get the member generation of the subscription, and remove all previously owned partitions as invalid if the current generation is higher. However, the logic before my fix, will remove the current highest member out of the `consumerToOwnedPartitions`. Fix this logic error.

*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*

*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*

### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang merged pull request #8777: KAFKA-10082: Fix the failed testMultiConsumerStickyAssignment

Posted by GitBox <gi...@apache.org>.

guozhangwang merged pull request #8777:
URL: https://github.com/apache/kafka/pull/8777


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ableegoldman commented on pull request #8777: KAFKA-10082: Fix the failed testMultiConsumerStickyAssignment

Posted by GitBox <gi...@apache.org>.

ableegoldman commented on pull request #8777:
URL: https://github.com/apache/kafka/pull/8777#issuecomment-637664149


   cc @mjsax @guozhangwang , should be cherrypicked to 2.6, 2.5, and 2.4


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang commented on pull request #8777: KAFKA-10082: Fix the failed testMultiConsumerStickyAssignment

Posted by GitBox <gi...@apache.org>.

guozhangwang commented on pull request #8777:
URL: https://github.com/apache/kafka/pull/8777#issuecomment-637677433


   Cherry-picked to 2.6 / 2.5 / 2.4


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #8777: KAFKA-10082: Fix the failed testMultiConsumerStickyAssignment

Posted by GitBox <gi...@apache.org>.

showuon commented on pull request #8777:
URL: https://github.com/apache/kafka/pull/8777#issuecomment-637344872


   @ableegoldman , could you check this PR to fix the failed tests? Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org