You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shindig.apache.org by MHarish Mnsatya <sa...@gmail.com> on 2010/10/12 16:12:54 UTC

[Shindig][Issue 2044045] Adding ImageAttributeRewriter that adds the height and width attributes if they are not specified.

Description:
Adding ImageAttributeRewriter that adds the height and width attributes
if they are not specified in the <img> tag.

Pros:
This helps in reducing the reflow's of the page when rendering it.

Cons:
Add extra burden of parsing the meta data of the images which may add to
the latency.

Please review this at http://codereview.appspot.com/2044045/

Affected files:
 java/gadgets/src/test/java/org/apache/shindig/gadgets/http/MultipleResourceHttpFetcherTest.java
 java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/ImageAttributeRewritterTest.java
 java/gadgets/src/main/java/org/apache/shindig/gadgets/http/MultipleResourceHttpFetcher.java
 java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ConcatProxyServlet.java
 java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/ImageAttributeRewriter.java

Regards,
Satya.