You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "nvazquez (via GitHub)" <gi...@apache.org> on 2023/12/08 19:40:52 UTC
[PR] Fix unmanage VM marvin tests and small UI fixes for import [cloudstack]
nvazquez opened a new pull request, #8338:
URL: https://github.com/apache/cloudstack/pull/8338
### Description
This PR fixes the failing smoke test for `test_vm_lifecycle_unmanage_import.py` for Vmware and adds a small UI fix on the import wizard
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix unmanage VM marvin tests and small UI fixes for import [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8338:
URL: https://github.com/apache/cloudstack/pull/8338#issuecomment-1853103700
<b>[SF] Trillian test result (tid-8557)</b>
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server a8
Total time taken: 49211 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8338-t8557-vmware-70u3.zip
Smoke tests completed. 119 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_DeployVmAntiAffinityGroup_in_project | `Error` | 98.98 | test_affinity_groups_projects.py
test_01_browser_migrate_template | `Failure` | 5.50 | test_image_store_object_migration.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix unmanage VM marvin tests and small UI fixes for import [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #8338:
URL: https://github.com/apache/cloudstack/pull/8338#issuecomment-1848437322
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix unmanage VM marvin tests and small UI fixes for import [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #8338:
URL: https://github.com/apache/cloudstack/pull/8338#issuecomment-1853269956
@DaanHoogland @harikrishna-patnala @rohityadavcloud cc @nvazquez oops I merged it a bit early. Do you approve or else I can revert?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix unmanage VM marvin tests and small UI fixes for import [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8338:
URL: https://github.com/apache/cloudstack/pull/8338#issuecomment-1848917081
<b>[SF] Trillian test result (tid-8531)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 132760 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8338-t8531-xenserver-71.zip
Smoke tests completed. 84 look OK, 37 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_DeployVmAntiAffinityGroup_in_project | `Error` | 110.28 | test_affinity_groups_projects.py
ContextSuite context=TestRemoteDiagnostics>:setup | `Error` | 0.00 | test_diagnostics.py
test_nic_secondaryip_add_remove | `Error` | 1514.01 | test_multipleips_per_nic.py
ContextSuite context=TestPortForwardingRules>:setup | `Error` | 0.00 | test_portforwardingrules.py
ContextSuite context=TestNestedVirtualization>:setup | `Error` | 0.00 | test_nested_virtualization.py
test_delete_account | `Error` | 1513.73 | test_network.py
test_delete_network_while_vm_on_it | `Error` | 1.18 | test_network.py
test_deploy_vm_l2network | `Error` | 1.15 | test_network.py
test_l2network_restart | `Error` | 1.27 | test_network.py
ContextSuite context=TestPortForwarding>:setup | `Error` | 2.48 | test_network.py
ContextSuite context=TestPublicIP>:setup | `Error` | 4.87 | test_network.py
test_reboot_router | `Failure` | 0.06 | test_network.py
test_releaseIP | `Error` | 2.21 | test_network.py
test_releaseIP_using_IP | `Error` | 2.59 | test_network.py
ContextSuite context=TestRouterRules>:setup | `Error` | 2.68 | test_network.py
ContextSuite context=TestSharedNetwork>:setup | `Error` | 3.00 | test_network.py
ContextSuite context=TestNetworkACL>:setup | `Error` | 0.00 | test_network_acl.py
ContextSuite context=TestDomainsServiceOfferings>:setup | `Error` | 1517.46 | test_domain_service_offerings.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup | `Error` | 0.00 | test_password_server.py
test_01_events_resource | `Error` | 1513.91 | test_events_resource.py
ContextSuite context=TestIpv6Network>:setup | `Error` | 0.00 | test_network_ipv6.py
test_01_browser_migrate_template | `Error` | 65.53 | test_image_store_object_migration.py
ContextSuite context=TestInternalLb>:setup | `Error` | 0.00 | test_internal_lb.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
test_01_create_ipv6_guest_prefix | `Error` | 0.06 | test_ipv6_infra.py
test_01_create_ipv6_public_ip_range | `Error` | 0.04 | test_ipv6_infra.py
ContextSuite context=TestScaleVm>:setup | `Error` | 0.00 | test_scale_vm.py
test_01_create_iso_with_checksum_sha1 | `Error` | 66.48 | test_iso.py
test_02_create_iso_with_checksum_sha256 | `Error` | 66.49 | test_iso.py
test_03_create_iso_with_checksum_md5 | `Error` | 66.47 | test_iso.py
test_04_create_iso_with_no_checksum | `Error` | 66.51 | test_iso.py
test_01_create_iso | `Failure` | 1515.25 | test_iso.py
ContextSuite context=TestISO>:setup | `Error` | 3029.76 | test_iso.py
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_11_test_unmanaged_cluster_lifecycle | `Error` | 0.01 | test_kubernetes_clusters.py
test_01_add_delete_kubernetes_supported_version | `Error` | 1801.82 | test_kubernetes_supported_versions.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 1514.07 | test_service_offerings.py
ContextSuite context=TestSetSourceNatIp>:setup | `Error` | 0.00 | test_set_sourcenat.py
test_01_create_template | `Error` | 22.75 | test_templates.py
test_CreateTemplateWithDuplicateName | `Error` | 56.63 | test_templates.py
test_02_create_template_with_checksum_sha1 | `Error` | 65.53 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 65.47 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 65.56 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 65.53 | test_templates.py
test_03_delete_template | `Error` | 1.09 | test_templates.py
test_04_extract_template | `Error` | 1.08 | test_templates.py
test_09_list_templates_download_details | `Failure` | 0.09 | test_templates.py
ContextSuite context=TestDeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | `Failure` | 1512.18 | test_vm_life_cycle.py
ContextSuite context=TestUnmanageVM>:setup | `Error` | 0.00 | test_vm_lifecycle_unmanage_import.py
ContextSuite context=TestChangeServiceOfferingForVmWithSnapshots>:setup | `Error` | 0.00 | test_vm_snapshots.py
test_04_deploy_vnf_appliance | `Error` | 311.88 | test_vnf_templates.py
ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py
test_06_download_detached_volume | `Error` | 192.59 | test_volumes.py
ContextSuite context=TestVolumes>:teardown | `Error` | 26.19 | test_volumes.py
ContextSuite context=TestIpv6Vpc>:setup | `Error` | 0.00 | test_vpc_ipv6.py
ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 1513.66 | test_host_maintenance.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix unmanage VM marvin tests and small UI fixes for import [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on code in PR #8338:
URL: https://github.com/apache/cloudstack/pull/8338#discussion_r1420968375
##########
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java:
##########
@@ -7154,6 +7154,7 @@ private Answer execute(GetUnmanagedInstancesCommand cmd) {
}
UnmanagedInstanceTO instance = VmwareHelper.getUnmanagedInstance(hyperHost, vmMo);
if (instance != null) {
+ instance.setCpuSpeed(vmMo.getConfigSummary().getCpuReservation());
Review Comment:
@nvazquez can `getConfigSummary()` return null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix unmanage VM marvin tests and small UI fixes for import [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #8338:
URL: https://github.com/apache/cloudstack/pull/8338#issuecomment-1848418615
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix unmanage VM marvin tests and small UI fixes for import [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8338:
URL: https://github.com/apache/cloudstack/pull/8338#issuecomment-1851802326
@DaanHoogland a [SL] Trillian-Jenkins test job (alma8 mgmt + vmware-70u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix unmanage VM marvin tests and small UI fixes for import [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8338:
URL: https://github.com/apache/cloudstack/pull/8338#issuecomment-1848453135
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8002
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix unmanage VM marvin tests and small UI fixes for import [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8338:
URL: https://github.com/apache/cloudstack/pull/8338#issuecomment-1851778817
@blueorangutan test alma8 vmware-70u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix unmanage VM marvin tests and small UI fixes for import [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr merged PR #8338:
URL: https://github.com/apache/cloudstack/pull/8338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix unmanage VM marvin tests and small UI fixes for import [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8338:
URL: https://github.com/apache/cloudstack/pull/8338#issuecomment-1847748440
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix unmanage VM marvin tests and small UI fixes for import [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #8338:
URL: https://github.com/apache/cloudstack/pull/8338#issuecomment-1847741791
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix unmanage VM marvin tests and small UI fixes for import [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8338:
URL: https://github.com/apache/cloudstack/pull/8338#issuecomment-1848367550
<b>[SF] Trillian test result (tid-8532)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 48536 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8338-t8532-vmware-67u3.zip
Smoke tests completed. 118 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_DeployVmAntiAffinityGroup_in_project | `Error` | 108.10 | test_affinity_groups_projects.py
test_01_browser_migrate_template | `Failure` | 5.40 | test_image_store_object_migration.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 761.72 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix unmanage VM marvin tests and small UI fixes for import [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #8338:
URL: https://github.com/apache/cloudstack/pull/8338#issuecomment-1848578324
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix unmanage VM marvin tests and small UI fixes for import [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8338:
URL: https://github.com/apache/cloudstack/pull/8338#issuecomment-1847825916
@nvazquez a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix unmanage VM marvin tests and small UI fixes for import [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8338:
URL: https://github.com/apache/cloudstack/pull/8338#issuecomment-1847821912
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix unmanage VM marvin tests and small UI fixes for import [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #8338:
URL: https://github.com/apache/cloudstack/pull/8338#issuecomment-1847824976
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix unmanage VM marvin tests and small UI fixes for import [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8338:
URL: https://github.com/apache/cloudstack/pull/8338#issuecomment-1848437437
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix unmanage VM marvin tests and small UI fixes for import [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #8338:
URL: https://github.com/apache/cloudstack/pull/8338#issuecomment-1847760229
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8338?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`4e46f5a`)](https://app.codecov.io/gh/apache/cloudstack/commit/4e46f5ad17fa16684b689c061c7cc52ad2e5b7cc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 27.91% compared to head [(`a04150b`)](https://app.codecov.io/gh/apache/cloudstack/pull/8338?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 4.42%.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #8338 +/- ##
============================================
- Coverage 27.91% 4.42% -23.50%
============================================
Files 5260 361 -4899
Lines 369732 28390 -341342
Branches 53891 4953 -48938
============================================
- Hits 103212 1256 -101956
+ Misses 252247 26996 -225251
+ Partials 14273 138 -14135
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8338/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8338/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8338/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.42% <ø> (ø)` | |
| [unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8338/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8338?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix unmanage VM marvin tests and small UI fixes for import [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8338:
URL: https://github.com/apache/cloudstack/pull/8338#issuecomment-1848361523
<b>[SF] Trillian test result (tid-8533)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46723 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8338-t8533-kvm-centos7.zip
Smoke tests completed. 121 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix unmanage VM marvin tests and small UI fixes for import [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on code in PR #8338:
URL: https://github.com/apache/cloudstack/pull/8338#discussion_r1421424918
##########
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java:
##########
@@ -7154,6 +7154,7 @@ private Answer execute(GetUnmanagedInstancesCommand cmd) {
}
UnmanagedInstanceTO instance = VmwareHelper.getUnmanagedInstance(hyperHost, vmMo);
if (instance != null) {
+ instance.setCpuSpeed(vmMo.getConfigSummary().getCpuReservation());
Review Comment:
Thanks, fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix unmanage VM marvin tests and small UI fixes for import [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8338:
URL: https://github.com/apache/cloudstack/pull/8338#issuecomment-1848578401
@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix unmanage VM marvin tests and small UI fixes for import [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8338:
URL: https://github.com/apache/cloudstack/pull/8338#issuecomment-1848874562
<b>[SF] Trillian test result (tid-8535)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48180 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8338-t8535-vmware-67u3.zip
Smoke tests completed. 119 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_DeployVmAntiAffinityGroup_in_project | `Error` | 113.39 | test_affinity_groups_projects.py
test_01_browser_migrate_template | `Failure` | 5.26 | test_image_store_object_migration.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org