You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2020/09/07 07:23:37 UTC
[GitHub] [httpcomponents-core] michael-o opened a new pull request #222: Master pom cleanup
michael-o opened a new pull request #222:
URL: https://github.com/apache/httpcomponents-core/pull/222
This completey aligns with Parent 12 and removes/unifies duplicate configuration.
If approved, it will be ported to 5.1.x too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o commented on pull request #222: Master pom cleanup
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #222:
URL: https://github.com/apache/httpcomponents-core/pull/222#issuecomment-688727418
OK, I know why this is failing for you, but not for me:
```
D:\Entwicklung\Projekte\httpcomponents-core5 [master ≡]> mvn -v
Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T20:33:14+02:00)
Maven home: D:\Entwicklung\Programme\apache-maven-3.5.4\bin\..
Java version: 1.7.0_272, vendor: Azul Systems, Inc., runtime: C:\Program Files\Zulu\zulu-7\jre
Default locale: de_DE, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
```
You still use Oracle JDK 7u80 instead of OpenJDK with has TLS 1.2 built in. Would you mind to use Azul Zulu or something else for Java 7 or do you still want to change the links to http://?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o closed pull request #222: Master pom cleanup
Posted by GitBox <gi...@apache.org>.
michael-o closed pull request #222:
URL: https://github.com/apache/httpcomponents-core/pull/222
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o commented on pull request #222: Master pom cleanup
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #222:
URL: https://github.com/apache/httpcomponents-core/pull/222#issuecomment-688677867
It's almost done anyway, but will keep that in mind for the future. Thanks for the heads up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on pull request #222: Master pom cleanup
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #222:
URL: https://github.com/apache/httpcomponents-core/pull/222#issuecomment-688683379
@michael-o There is slight problem. It looks like the `javadoc` plugin does not work well with the new setup.
I am seeing those warnings when running `mvn clean javadoc:javadoc`
```
[INFO] --- maven-javadoc-plugin:3.2.0:javadoc (default-cli) @ httpcore5 ---
[INFO] Toolchain in maven-javadoc-plugin: JDK[/opt/oracle-jdk-1.7.0]
[INFO] No previous run data found, generating javadoc.
[INFO]
2 warnings
[WARNING] Javadoc Warnings
[WARNING] javadoc: warning - Error fetching URL: https://hc.apache.org/httpcomponents-core-5.0.x//httpcore5/apidocs/package-list
[WARNING] javadoc: warning - Error fetching URL: https://hc.apache.org/httpcomponents-core-5.0.x//httpcore5-h2/apidocs/package-list
```
If I change link references to use `http` everything appears to be good again
```
<plugin>
<artifactId>maven-javadoc-plugin</artifactId>
<configuration>
<links>
<link>http://hc.apache.org/httpcomponents-core-5.0.x/httpcore5/apidocs/</link>
<link>http://hc.apache.org/httpcomponents-core-5.0.x/httpcore5-h2/apidocs/</link>
</links>
</configuration>
</plugin>
```
We need to fix this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on pull request #222: Master pom cleanup
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #222:
URL: https://github.com/apache/httpcomponents-core/pull/222#issuecomment-688729810
@michael-o I will see if I can upgrade my current JDK 1.7 to something newer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on pull request #222: Master pom cleanup
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #222:
URL: https://github.com/apache/httpcomponents-core/pull/222#issuecomment-688655792
@michael-o You do not really need to do that. I regularly re-base 5.1.x off master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o commented on pull request #222: Master pom cleanup
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #222:
URL: https://github.com/apache/httpcomponents-core/pull/222#issuecomment-688691964
That's weird. I will have a look whether I can reproduce this here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o commented on pull request #222: Master pom cleanup
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #222:
URL: https://github.com/apache/httpcomponents-core/pull/222#issuecomment-688639729
Merged into master, 5.1.x will follow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org