[GitHub] [tvm] mbs-octoml opened a new pull request #9076: BUG #8013: Remove register_alter_op_layout example from dev/use_pass_infra.py

[GitBox <gi...@apache.org>]

mbs-octoml opened a new pull request #9076:
URL: https://github.com/apache/tvm/pull/9076


   This tutorial registers a global layout transformation for conv2d for all
   targets which is not well-formed. Later uses of conv2d in the tutorials
   pick that layout up then assert fail in the conv2d type-relation.
   
   Better would be to register a transform for an entirely fake target, but
   that is beyond my current level of expertise.
   
   In general our use of sphinx/sphinx_gallery for running and rendering the
   tutorials is highly suspect since there is no inter-example isolation:
    - Examples using tensorflow will gobble up GPU memory and not give it back.
    - Any examples which use any of the (many!) global registration mechanisms
      need to ensure the registrant is safe across all tutorials.
   I recall seeing a thread with the sphinx_gallery where they said they'd prefer
   not to work on process-level isolation, but it's probably worth pinging again.
   
   While digging into this I noticed we had a slicing cast in AlterOpLayout due
   to a derived class of ObjectRef introducing virtuals. I moved the virtuals to
   the corresponding Node classes. In this case we got away with it since the
   ObjectRef happened to not get copied but we were on very thin ice.
   
   Thanks for contributing to TVM!   Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao1994 commented on pull request #9076: BUG #8013: Remove register_alter_op_layout example from dev/use_pass_infra.py

[GitBox <gi...@apache.org>]

junrushao1994 commented on pull request #9076:
URL: https://github.com/apache/tvm/pull/9076#issuecomment-925979887


   Thanks @mbs-octoml @jroesch!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] jroesch commented on pull request #9076: BUG #8013: Remove register_alter_op_layout example from dev/use_pass_infra.py

[GitBox <gi...@apache.org>]

jroesch commented on pull request #9076:
URL: https://github.com/apache/tvm/pull/9076#issuecomment-925975088


   @mbs-octoml can we just put a backlog item on fixing the tutorial? going to merge for CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao1994 merged pull request #9076: BUG #8013: Remove register_alter_op_layout example from dev/use_pass_infra.py

[GitBox <gi...@apache.org>]

junrushao1994 merged pull request #9076:
URL: https://github.com/apache/tvm/pull/9076


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org