You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/02 10:11:31 UTC
[GitHub] [pulsar] Demogorgon314 opened a new pull request #12585: Fix additional servlets nar might extract to null directory
Demogorgon314 opened a new pull request #12585:
URL: https://github.com/apache/pulsar/pull/12585
### Motivation
The additional servlets use NAR package to implantation plugin mechanism, it need extract to specific directory.
However, the `narExtractionDirectory` is from `Properties`, but the properties has only the configuration in the
configuration file. The default value of `narExtractionDirectory ` in `ServiceConfiguration` can't be use.
### Modifications
When `narExtractionDirectory ` configuration is not set, use `NarClassLoader.DEFAULT_NAR_EXTRACTION_DIR` as default directory.
### Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
### Documentation
- [x] `no-need-doc`
This a bug fix, no need docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #12585: Fix additional servlets nar might extract to null directory
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12585:
URL: https://github.com/apache/pulsar/pull/12585#issuecomment-957315861
@Demogorgon314:Thanks for providing doc info!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Demogorgon314 commented on pull request #12585: Fix additional servlets nar might extract to null directory
Posted by GitBox <gi...@apache.org>.
Demogorgon314 commented on pull request #12585:
URL: https://github.com/apache/pulsar/pull/12585#issuecomment-958587042
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Demogorgon314 commented on pull request #12585: Fix additional servlets nar might extract to null directory
Posted by GitBox <gi...@apache.org>.
Demogorgon314 commented on pull request #12585:
URL: https://github.com/apache/pulsar/pull/12585#issuecomment-958587042
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Demogorgon314 commented on pull request #12585: Fix additional servlets nar might extract to null directory
Posted by GitBox <gi...@apache.org>.
Demogorgon314 commented on pull request #12585:
URL: https://github.com/apache/pulsar/pull/12585#issuecomment-958587042
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #12585: Fix additional servlets nar might extract to null directory
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12585:
URL: https://github.com/apache/pulsar/pull/12585#issuecomment-957315861
@Demogorgon314:Thanks for providing doc info!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #12585: Fix additional servlets nar might extract to null directory
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12585:
URL: https://github.com/apache/pulsar/pull/12585#issuecomment-957315861
@Demogorgon314:Thanks for providing doc info!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #12585: Fix additional servlets nar might extract to null directory
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #12585:
URL: https://github.com/apache/pulsar/pull/12585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org