You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "zechenj18 (via GitHub)" <gi...@apache.org> on 2023/08/03 20:23:21 UTC
[GitHub] [beam] zechenj18 opened a new pull request, #27837: Rebuild generated protobuf code to reflect fnapi proto update #25065
zechenj18 opened a new pull request, #27837:
URL: https://github.com/apache/beam/pull/27837
- Rebuild generated protobuf code to reflect fnapi proto update for data sampling #25065
This rebuild generated protobuf code in go sdk to apply updates in fnapi proto
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #27837: Rebuild generated protobuf code to reflect fnapi proto update #25065
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #27837:
URL: https://github.com/apache/beam/pull/27837#issuecomment-1664753970
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/27837?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#27837](https://app.codecov.io/gh/apache/beam/pull/27837?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e4161d0) into [master](https://app.codecov.io/gh/apache/beam/commit/1372572f0666b9252b7b22d977356c1b198663a7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1372572) will **increase** coverage by `0.00%`.
> Report is 7 commits behind head on master.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #27837 +/- ##
=======================================
Coverage 70.87% 70.88%
=======================================
Files 861 861
Lines 104995 104995
=======================================
+ Hits 74413 74422 +9
+ Misses 29023 29015 -8
+ Partials 1559 1558 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| go | `53.71% <ø> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 13 files with indirect coverage changes](https://app.codecov.io/gh/apache/beam/pull/27837/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #27837: Rebuild generated protobuf code to reflect fnapi proto update #25065
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #27837:
URL: https://github.com/apache/beam/pull/27837#issuecomment-1664747242
Thanks and LGTM, I'll merge once these pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] zechenj18 commented on pull request #27837: Rebuild generated protobuf code to reflect fnapi proto update #25065
Posted by "zechenj18 (via GitHub)" <gi...@apache.org>.
zechenj18 commented on PR #27837:
URL: https://github.com/apache/beam/pull/27837#issuecomment-1664610075
R: @lostluck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck merged pull request #27837: Rebuild generated protobuf code to reflect fnapi proto update #25065
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck merged PR #27837:
URL: https://github.com/apache/beam/pull/27837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #27837: Rebuild generated protobuf code to reflect fnapi proto update #25065
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27837:
URL: https://github.com/apache/beam/pull/27837#issuecomment-1664611795
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org