You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Timothy Bish (JIRA)" <ji...@apache.org> on 2006/11/26 16:30:02 UTC

[jira] Created: (AMQCPP-16) CMS API needs updates to more closely follow JMS API

CMS API needs updates to more closely follow JMS API
----------------------------------------------------

                 Key: AMQCPP-16
                 URL: https://issues.apache.org/activemq/browse/AMQCPP-16
             Project: ActiveMQ C++ Client
          Issue Type: Improvement
          Components: CMS Impl
    Affects Versions: 1.1, 2.0
            Reporter: Timothy Bish
         Assigned To: Timothy Bish
            Priority: Minor
             Fix For: 1.1


The CMS API interfaces need updates so that they more closely follow the JMS API:

1.  Change longs to long long types.
2.  The ReplyTo accessors should handle cms::Destination pointers, not strings

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (AMQCPP-16) CMS API needs updates to more closely follow JMS API

Posted by "Nathan Mittler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQCPP-16?page=comments#action_37685 ] 
            
Nathan Mittler commented on AMQCPP-16:
--------------------------------------

1) has been implemented in trunk.  This required changes to DataInput/OutputStreams and ByteArrayInput/OuptutStreams to facilitate the new BytesMessage API.

I also update the InputStream and OutputStream APIs to remove "const" where not necessary.

Tim, give this a try in windows (regarding the const changes) ... gcc is very giving on this particular issue :)

Also, could you comment on any of the others that you have implemented in trunk?  Thanks.

> CMS API needs updates to more closely follow JMS API
> ----------------------------------------------------
>
>                 Key: AMQCPP-16
>                 URL: https://issues.apache.org/activemq/browse/AMQCPP-16
>             Project: ActiveMQ C++ Client
>          Issue Type: Improvement
>          Components: CMS Impl
>    Affects Versions: 1.1, 2.0
>            Reporter: Timothy Bish
>         Assigned To: Timothy Bish
>            Priority: Minor
>             Fix For: 1.1
>
>
> The CMS API interfaces need updates so that they more closely follow the JMS API:
> 1.  Change longs to long long types.
> 2.  The ReplyTo accessors should handle cms::Destination pointers, not strings

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (AMQCPP-16) CMS API needs updates to more closely follow JMS API

Posted by "Nathan Mittler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQCPP-16?page=comments#action_37570 ] 
            
Nathan Mittler commented on AMQCPP-16:
--------------------------------------

I've changed CMS::Message to match the JMS Message property methods.  I have only modified the Stomp implementation.  For building, I've temporarily commented out the inclusion of the openwire classes.

> CMS API needs updates to more closely follow JMS API
> ----------------------------------------------------
>
>                 Key: AMQCPP-16
>                 URL: https://issues.apache.org/activemq/browse/AMQCPP-16
>             Project: ActiveMQ C++ Client
>          Issue Type: Improvement
>          Components: CMS Impl
>    Affects Versions: 1.1, 2.0
>            Reporter: Timothy Bish
>         Assigned To: Timothy Bish
>            Priority: Minor
>             Fix For: 1.1
>
>
> The CMS API interfaces need updates so that they more closely follow the JMS API:
> 1.  Change longs to long long types.
> 2.  The ReplyTo accessors should handle cms::Destination pointers, not strings

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (AMQCPP-16) CMS API needs updates to more closely follow JMS API

Posted by "Nathan Mittler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQCPP-16?page=comments#action_37559 ] 
            
Nathan Mittler commented on AMQCPP-16:
--------------------------------------

I've committed the two extra send methods in the MessageProducer to trunk as part of my checkin for AMQCPP-14

> CMS API needs updates to more closely follow JMS API
> ----------------------------------------------------
>
>                 Key: AMQCPP-16
>                 URL: https://issues.apache.org/activemq/browse/AMQCPP-16
>             Project: ActiveMQ C++ Client
>          Issue Type: Improvement
>          Components: CMS Impl
>    Affects Versions: 1.1, 2.0
>            Reporter: Timothy Bish
>         Assigned To: Timothy Bish
>            Priority: Minor
>             Fix For: 1.1
>
>
> The CMS API interfaces need updates so that they more closely follow the JMS API:
> 1.  Change longs to long long types.
> 2.  The ReplyTo accessors should handle cms::Destination pointers, not strings

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (AMQCPP-16) CMS API needs updates to more closely follow JMS API

Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQCPP-16?page=comments#action_37565 ] 
            
Timothy Bish commented on AMQCPP-16:
------------------------------------

I Committed the changes for the CMS Api so that all long types are now long long (64bit).  

> CMS API needs updates to more closely follow JMS API
> ----------------------------------------------------
>
>                 Key: AMQCPP-16
>                 URL: https://issues.apache.org/activemq/browse/AMQCPP-16
>             Project: ActiveMQ C++ Client
>          Issue Type: Improvement
>          Components: CMS Impl
>    Affects Versions: 1.1, 2.0
>            Reporter: Timothy Bish
>         Assigned To: Timothy Bish
>            Priority: Minor
>             Fix For: 1.1
>
>
> The CMS API interfaces need updates so that they more closely follow the JMS API:
> 1.  Change longs to long long types.
> 2.  The ReplyTo accessors should handle cms::Destination pointers, not strings

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (AMQCPP-16) CMS API needs updates to more closely follow JMS API

Posted by "Nathan Mittler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQCPP-16?page=comments#action_37557 ] 
            
Nathan Mittler commented on AMQCPP-16:
--------------------------------------

Add the following flavors of the send method to MessageProducer:

send(Destination destination, Message message, int deliveryMode, int priority, long timeToLive)

send(Message message, int deliveryMode, int priority, long timeToLive) 

> CMS API needs updates to more closely follow JMS API
> ----------------------------------------------------
>
>                 Key: AMQCPP-16
>                 URL: https://issues.apache.org/activemq/browse/AMQCPP-16
>             Project: ActiveMQ C++ Client
>          Issue Type: Improvement
>          Components: CMS Impl
>    Affects Versions: 1.1, 2.0
>            Reporter: Timothy Bish
>         Assigned To: Timothy Bish
>            Priority: Minor
>             Fix For: 1.1
>
>
> The CMS API interfaces need updates so that they more closely follow the JMS API:
> 1.  Change longs to long long types.
> 2.  The ReplyTo accessors should handle cms::Destination pointers, not strings

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (AMQCPP-16) CMS API needs updates to more closely follow JMS API

Posted by "Nathan Mittler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQCPP-16?page=all ]

Nathan Mittler closed AMQCPP-16.
--------------------------------

    Resolution: Fixed
      Assignee: Nathan Mittler  (was: Timothy Bish)

At this point, we have implemented 3 of the 4 changes.  We're going to push out the implementation of the recover method for now.  If someone really wants that functionality, we can create another issue in the future.

> CMS API needs updates to more closely follow JMS API
> ----------------------------------------------------
>
>                 Key: AMQCPP-16
>                 URL: https://issues.apache.org/activemq/browse/AMQCPP-16
>             Project: ActiveMQ C++ Client
>          Issue Type: Improvement
>          Components: CMS Impl
>    Affects Versions: 1.1, 2.0
>            Reporter: Timothy Bish
>         Assigned To: Nathan Mittler
>            Priority: Minor
>             Fix For: 1.1
>
>
> The CMS API interfaces need updates so that they more closely follow the JMS API:
> 1.  Change longs to long long types.
> 2.  The ReplyTo accessors should handle cms::Destination pointers, not strings

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (AMQCPP-16) CMS API needs updates to more closely follow JMS API

Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQCPP-16?page=comments#action_37689 ] 
            
Timothy Bish commented on AMQCPP-16:
------------------------------------

2) CMS::MessageConsumer and CMS::MessageProducer do not have a close method
3) CMS::Session does not have a createConsumer method that takes noLocal as an argument

I've implemented both of these in trunk.

I also fixed some constness issues that you created in the VC build.  :)


> CMS API needs updates to more closely follow JMS API
> ----------------------------------------------------
>
>                 Key: AMQCPP-16
>                 URL: https://issues.apache.org/activemq/browse/AMQCPP-16
>             Project: ActiveMQ C++ Client
>          Issue Type: Improvement
>          Components: CMS Impl
>    Affects Versions: 1.1, 2.0
>            Reporter: Timothy Bish
>         Assigned To: Timothy Bish
>            Priority: Minor
>             Fix For: 1.1
>
>
> The CMS API interfaces need updates so that they more closely follow the JMS API:
> 1.  Change longs to long long types.
> 2.  The ReplyTo accessors should handle cms::Destination pointers, not strings

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (AMQCPP-16) CMS API needs updates to more closely follow JMS API

Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQCPP-16?page=comments#action_37683 ] 
            
Timothy Bish commented on AMQCPP-16:
------------------------------------

I think that these are okay to get into the next release

1) Bytes message as defined by JMS should have methods similar to an input stream for reading/writing primitives.
2) CMS::MessageConsumer and CMS::MessageProducer do not have a close method
3) CMS::Session does not have a createConsumer method that takes noLocal as an argument

But this one would require some serious effort at this point and I'd rather see that one go in later so that we get these others into a 1.1 release sooner.

4) CMS::Session does not have a recover method

> CMS API needs updates to more closely follow JMS API
> ----------------------------------------------------
>
>                 Key: AMQCPP-16
>                 URL: https://issues.apache.org/activemq/browse/AMQCPP-16
>             Project: ActiveMQ C++ Client
>          Issue Type: Improvement
>          Components: CMS Impl
>    Affects Versions: 1.1, 2.0
>            Reporter: Timothy Bish
>         Assigned To: Timothy Bish
>            Priority: Minor
>             Fix For: 1.1
>
>
> The CMS API interfaces need updates so that they more closely follow the JMS API:
> 1.  Change longs to long long types.
> 2.  The ReplyTo accessors should handle cms::Destination pointers, not strings

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (AMQCPP-16) CMS API needs updates to more closely follow JMS API

Posted by "Nathan Mittler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQCPP-16?page=comments#action_37617 ] 
            
Nathan Mittler commented on AMQCPP-16:
--------------------------------------

A couple others that deviate from the JMS spec that we may want to consider

1) Bytes message as defined by JMS should have methods similar to an input stream for reading/writing primitives.
2) CMS::MessageConsumer  and CMS::MessageProducer do not have a close method
3) CMS::Session does not have a createConsumer method that takes noLocal as an argument
4) CMS::Session does not have a recover method

> CMS API needs updates to more closely follow JMS API
> ----------------------------------------------------
>
>                 Key: AMQCPP-16
>                 URL: https://issues.apache.org/activemq/browse/AMQCPP-16
>             Project: ActiveMQ C++ Client
>          Issue Type: Improvement
>          Components: CMS Impl
>    Affects Versions: 1.1, 2.0
>            Reporter: Timothy Bish
>         Assigned To: Timothy Bish
>            Priority: Minor
>             Fix For: 1.1
>
>
> The CMS API interfaces need updates so that they more closely follow the JMS API:
> 1.  Change longs to long long types.
> 2.  The ReplyTo accessors should handle cms::Destination pointers, not strings

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira