[GitHub] zhreshold commented on a change in pull request #11247: Add seed_aug parameter for ImageRecordItr to fix random seed for default augmentation

[GitBox <gi...@apache.org>]

zhreshold commented on a change in pull request #11247: Add seed_aug parameter for ImageRecordItr to fix random seed for default augmentation
URL: https://github.com/apache/incubator-mxnet/pull/11247#discussion_r196244927
 
 

 ##########
 File path: src/io/image_aug_default.cc
 ##########
 @@ -136,6 +139,8 @@ struct DefaultImageAugmentParam : public dmlc::Parameter<DefaultImageAugmentPara
     DMLC_DECLARE_FIELD(pad).set_default(0)
         .describe("Change size from ``[width, height]`` into "
                   "``[pad + width + pad, pad + height + pad]`` by padding pixes");
+    DMLC_DECLARE_FIELD(seed_aug).set_default(-1)
 
 Review comment:
   better use dmlc::optional<int>() and check has_value() rather than compare with -1. 
   Literally we can use any number as seed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services