You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/21 08:55:59 UTC

[GitHub] [airflow] kadai0308 commented on a change in pull request #21694: set maxsplit to be 1 of line split in _parse_env_file function

kadai0308 commented on a change in pull request #21694:
URL: https://github.com/apache/airflow/pull/21694#discussion_r810900838



##########
File path: airflow/secrets/local_filesystem.py
##########
@@ -74,7 +74,7 @@ def _parse_env_file(file_path: str) -> Tuple[Dict[str, List[str]], List[FileSynt
             # Ignore comments
             continue
 
-        var_parts: List[str] = line.split("=", 2)
+        var_parts: List[str] = line.split("=", 1)

Review comment:
       Thanks for your comment, it did looks more elegant, let me update the code by using partition.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org