[GitHub] [netbeans] vieiro commented on pull request #5379: Fixed erroneous direct form of comparison ("==") for these object typ…

["vieiro (via GitHub)" <gi...@apache.org>]

vieiro commented on PR #5379:
URL: https://github.com/apache/netbeans/pull/5379#issuecomment-1407592053

   Some questions:
   
   > Fixed erroneous direct form of comparison ("==") for these object types: String, Integer, Boolean, BigDecimal
   
   1. Of all the changes you're proposing, which of them do you think are really erroneous?
   2. Let's assume NetBeans is working on erroneous code, as you say. Then if we apply all these changes to all these modules, NetBeans will work differently, right? Of all these modules you propose to change, where exactly is going NetBeans to work differently?
   
   > There is no guarantee that the given type located in the pool, so they can be in different objects and == will return false while equals will return true
   
   That is a good hint to evaluate the PR, and may help you answer point 2.  In which of the modules you propose to change is the type located in the pool? In the enterprise module? Web module? apisupport module? xml module? Java module? ant debugger module? Any other modules?
   
   We have to evaluate the impact of changes in the behavior of NetBeans! What is your opinion?
   
   Thanks,
   Antonio


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists