You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/05/21 00:55:50 UTC
Review Request: Cleanups in configure.ac.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11282/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Description
-------
See summary.
Diffs
-----
third_party/libprocess/configure.ac 329fa4745e01ec99e2ca4063ee5c5f2a72f24969
Diff: https://reviews.apache.org/r/11282/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Cleanups in configure.ac.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11282/#review21032
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On May 20, 2013, 10:55 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11282/
> -----------------------------------------------------------
>
> (Updated May 20, 2013, 10:55 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> third_party/libprocess/configure.ac 329fa4745e01ec99e2ca4063ee5c5f2a72f24969
>
> Diff: https://reviews.apache.org/r/11282/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Cleanups in configure.ac.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On May 21, 2013, 10:17 p.m., Vinod Kone wrote:
> > third_party/libprocess/configure.ac, lines 72-80
> > <https://reviews.apache.org/r/11282/diff/1/?file=294938#file294938line72>
> >
> > Why did you have to pull it up from where its used?
Because doing OS specific setup should probably be done at the beginning of configuration, just like it is in Mesos.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11282/#review20867
-----------------------------------------------------------
On May 20, 2013, 10:55 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11282/
> -----------------------------------------------------------
>
> (Updated May 20, 2013, 10:55 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> third_party/libprocess/configure.ac 329fa4745e01ec99e2ca4063ee5c5f2a72f24969
>
> Diff: https://reviews.apache.org/r/11282/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Cleanups in configure.ac.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11282/#review20867
-----------------------------------------------------------
third_party/libprocess/configure.ac
<https://reviews.apache.org/r/11282/#comment42973>
Why did you have to pull it up from where its used?
- Vinod Kone
On May 20, 2013, 10:55 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11282/
> -----------------------------------------------------------
>
> (Updated May 20, 2013, 10:55 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> third_party/libprocess/configure.ac 329fa4745e01ec99e2ca4063ee5c5f2a72f24969
>
> Diff: https://reviews.apache.org/r/11282/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>