[GitHub] [zookeeper] eolivelli commented on a diff in pull request #1847: ZOOKEEPER-4508: Fix endless-loop in ClientCnxn.SendThread.run when all zk servers down

["eolivelli (via GitHub)" <gi...@apache.org>]

eolivelli commented on code in PR #1847:
URL: https://github.com/apache/zookeeper/pull/1847#discussion_r1195082169


##########
zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java:
##########
@@ -1192,7 +1192,6 @@ public void run() {
                         startConnect(serverAddress);
                         // Update now to start the connection timer right after we make a connection attempt
                         clientCnxnSocket.updateNow();
-                        clientCnxnSocket.updateLastSendAndHeard();

Review Comment:
   why are you removing updateLastSendAndHeard ? (here and there)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org