You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Jens Geyer (JIRA)" <ji...@apache.org> on 2012/05/20 03:06:40 UTC

[jira] [Created] (THRIFT-1611) Improved code generation for typedefs

Jens Geyer created THRIFT-1611:
----------------------------------

             Summary: Improved code generation for typedefs
                 Key: THRIFT-1611
                 URL: https://issues.apache.org/jira/browse/THRIFT-1611
             Project: Thrift
          Issue Type: Improvement
          Components: Delphi - Compiler
            Reporter: Jens Geyer




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (THRIFT-1611) Improved code generation for typedefs

Posted by "Jens Geyer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer updated THRIFT-1611:
-------------------------------

    Description: Currently, IDL typedefs are translated into their base types and do not appear in the generated code at all. An example for this is the TMyInteger type from the tutorial.
     Patch Info: Patch Available
    
> Improved code generation for typedefs
> -------------------------------------
>
>                 Key: THRIFT-1611
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1611
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Delphi - Compiler
>            Reporter: Jens Geyer
>         Attachments: THRIFT-1611_Improved_code_generation_for_typedefs.patch
>
>
> Currently, IDL typedefs are translated into their base types and do not appear in the generated code at all. An example for this is the TMyInteger type from the tutorial.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (THRIFT-1611) Improved code generation for typedefs

Posted by "Jens Geyer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer updated THRIFT-1611:
-------------------------------

    Attachment: THRIFT-1611_Improved_code_generation_for_typedefs - rev2.patch

* removed the "type A = type B;" syntax into "type A = B;" to prevent compatibility issues with existing code
* modified initialisation of known types list 

                
> Improved code generation for typedefs
> -------------------------------------
>
>                 Key: THRIFT-1611
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1611
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Delphi - Compiler
>            Reporter: Jens Geyer
>         Attachments: THRIFT-1611_Improved_code_generation_for_typedefs - rev2.patch
>
>
> Currently, IDL typedefs are translated into their base types and do not appear in the generated code at all. An example for this is the TMyInteger type from the tutorial.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Comment Edited] (THRIFT-1611) Improved code generation for typedefs

Posted by "Jens Geyer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279849#comment-13279849 ] 

Jens Geyer edited comment on THRIFT-1611 at 5/20/12 7:47 PM:
-------------------------------------------------------------

* changed the "type A = type B;" syntax into "type A = B;" to prevent compatibility issues with existing code
* modified initialisation of known types list 

                
      was (Author: jensg):
    * removed the "type A = type B;" syntax into "type A = B;" to prevent compatibility issues with existing code
* modified initialisation of known types list 

                  
> Improved code generation for typedefs
> -------------------------------------
>
>                 Key: THRIFT-1611
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1611
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Delphi - Compiler
>            Reporter: Jens Geyer
>         Attachments: THRIFT-1611_Improved_code_generation_for_typedefs - rev2.patch
>
>
> Currently, IDL typedefs are translated into their base types and do not appear in the generated code at all. An example for this is the TMyInteger type from the tutorial.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (THRIFT-1611) Improved code generation for typedefs

Posted by "Jens Geyer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279645#comment-13279645 ] 

Jens Geyer commented on THRIFT-1611:
------------------------------------

Currently, IDL typedefs are translated into their base types and do not appear in the generated code at all. An example for this is the TMyInteger type from the tutorial.
                
> Improved code generation for typedefs
> -------------------------------------
>
>                 Key: THRIFT-1611
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1611
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Delphi - Compiler
>            Reporter: Jens Geyer
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (THRIFT-1611) Improved code generation for typedefs

Posted by "Jake Farrell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jake Farrell closed THRIFT-1611.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 0.9
         Assignee: Jens Geyer

committed
                
> Improved code generation for typedefs
> -------------------------------------
>
>                 Key: THRIFT-1611
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1611
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Delphi - Compiler
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>             Fix For: 0.9
>
>         Attachments: THRIFT-1611_Improved_code_generation_for_typedefs - rev2.patch
>
>
> Currently, IDL typedefs are translated into their base types and do not appear in the generated code at all. An example for this is the TMyInteger type from the tutorial.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (THRIFT-1611) Improved code generation for typedefs

Posted by "Jens Geyer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer updated THRIFT-1611:
-------------------------------

    Attachment:     (was: THRIFT-1611_Improved_code_generation_for_typedefs.patch)
    
> Improved code generation for typedefs
> -------------------------------------
>
>                 Key: THRIFT-1611
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1611
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Delphi - Compiler
>            Reporter: Jens Geyer
>         Attachments: THRIFT-1611_Improved_code_generation_for_typedefs - rev2.patch
>
>
> Currently, IDL typedefs are translated into their base types and do not appear in the generated code at all. An example for this is the TMyInteger type from the tutorial.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (THRIFT-1611) Improved code generation for typedefs

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279918#comment-13279918 ] 

Hudson commented on THRIFT-1611:
--------------------------------

Integrated in Thrift #483 (See [https://builds.apache.org/job/Thrift/483/])
    Thrift-1611:Improved code generation for typedefs
Client: delphi
Patch: Jens Geyer

Currently, IDL typedefs are translated into their base types and do not appear in the generated code at all (Revision 1340873)

     Result = ABORTED
                
> Improved code generation for typedefs
> -------------------------------------
>
>                 Key: THRIFT-1611
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1611
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Delphi - Compiler
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>             Fix For: 0.9
>
>         Attachments: THRIFT-1611_Improved_code_generation_for_typedefs - rev2.patch
>
>
> Currently, IDL typedefs are translated into their base types and do not appear in the generated code at all. An example for this is the TMyInteger type from the tutorial.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (THRIFT-1611) Improved code generation for typedefs

Posted by "Jens Geyer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer updated THRIFT-1611:
-------------------------------

    Attachment: THRIFT-1611_Improved_code_generation_for_typedefs.patch

Types defined via typedef will be generated as expected after this patch is applied.
                
> Improved code generation for typedefs
> -------------------------------------
>
>                 Key: THRIFT-1611
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1611
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Delphi - Compiler
>            Reporter: Jens Geyer
>         Attachments: THRIFT-1611_Improved_code_generation_for_typedefs.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira