[GitHub] [trafficcontrol] alexluckerman commented on a change in pull request #3727: Fix bug that causes DS requests to fulfill immediately while other requests are still open

[GitBox <gi...@apache.org>]

alexluckerman commented on a change in pull request #3727: Fix bug that causes DS requests to fulfill immediately while other requests are still open
URL: https://github.com/apache/trafficcontrol/pull/3727#discussion_r304629131
 
 

 ##########
 File path: traffic_portal/test/end_to_end/DeliveryServiceRequests/delivery-service-requests-spec.js
 ##########
 @@ -144,6 +144,7 @@ describe('Traffic Portal Delivery Service Requests', function() {
 		pageData.deleteButton.click();
 		pageData.confirmWithNameInput.sendKeys(mockVals.xmlId + ' request');
 		pageData.deletePermanentlyButton.click();
+		browser.sleep(250);
 		expect(browser.getCurrentUrl().then(commonFunctions.urlPath)).toEqual(commonFunctions.urlPath(browser.baseUrl)+"#!/delivery-service-requests");
 
 Review comment:
   Based off the test I was working on this morning, it seems to me that `expect()` will wait until promises are resolved before performing its comparisons, so the issue is just `browser.getCurrentUrl()` needs a bit of wait before it returns the correct value. But I couldn't find anything to corroborate that online, so ¯\\\__(ツ)__/¯

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services