You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/19 21:35:36 UTC
[GitHub] [arrow-datafusion-python] jdye64 opened a new pull request, #145: Substrait bindings
jdye64 opened a new pull request, #145:
URL: https://github.com/apache/arrow-datafusion-python/pull/145
# Which issue does this PR close?
Closes #132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove merged pull request #145: Substrait bindings
Posted by GitBox <gi...@apache.org>.
andygrove merged PR #145:
URL: https://github.com/apache/arrow-datafusion-python/pull/145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] jdye64 commented on pull request #145: Substrait bindings
Posted by GitBox <gi...@apache.org>.
jdye64 commented on PR #145:
URL: https://github.com/apache/arrow-datafusion-python/pull/145#issuecomment-1398497972
Hey @andygrove thanks! However, something is broken with the Github actions setup. While this PR showed all the CI passing that was actually a red herring. Only a single RAT action ran. I have another open issue for getting that resolved [here](https://github.com/apache/arrow-datafusion-python/issues/146) I actually think we need to revert this commit or otherwise any further CI jobs will always fail until that `maturin-action` is added to the Apache whitelist of actions allowed to be used in this repo.
Or we can just expect that to be done today and wait. Up to you but wanted to let you know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove commented on a diff in pull request #145: Substrait bindings
Posted by GitBox <gi...@apache.org>.
andygrove commented on code in PR #145:
URL: https://github.com/apache/arrow-datafusion-python/pull/145#discussion_r1081904324
##########
Cargo.toml:
##########
@@ -34,10 +34,11 @@ default = ["mimalloc"]
tokio = { version = "1.24", features = ["macros", "rt", "rt-multi-thread", "sync"] }
rand = "0.8"
pyo3 = { version = "~0.17.3", features = ["extension-module", "abi3", "abi3-py37"] }
-datafusion = { version = "16.0.0", features = ["pyarrow", "avro"] }
-datafusion-expr = { version = "16.0.0" }
-datafusion-optimizer = { version = "16.0.0" }
-datafusion-common = { version = "16.0.0", features = ["pyarrow"] }
+datafusion = { git = "https://github.com/apache/arrow-datafusion", branch = "master", features = ["pyarrow", "avro"] }
+datafusion-expr = { git = "https://github.com/apache/arrow-datafusion", branch = "master" }
+datafusion-optimizer = { git = "https://github.com/apache/arrow-datafusion", branch = "master" }
+datafusion-common = { git = "https://github.com/apache/arrow-datafusion", branch = "master", features = ["pyarrow"] }
+datafusion-substrait = { git = "https://github.com/apache/arrow-datafusion", branch = "master" }
Review Comment:
Let's pin to a specific git rev here rather than master to keep the master branch here stable. We can PR to increase the rev as often as we need to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] jdye64 commented on a diff in pull request #145: Substrait bindings
Posted by GitBox <gi...@apache.org>.
jdye64 commented on code in PR #145:
URL: https://github.com/apache/arrow-datafusion-python/pull/145#discussion_r1081905337
##########
Cargo.toml:
##########
@@ -34,10 +34,11 @@ default = ["mimalloc"]
tokio = { version = "1.24", features = ["macros", "rt", "rt-multi-thread", "sync"] }
rand = "0.8"
pyo3 = { version = "~0.17.3", features = ["extension-module", "abi3", "abi3-py37"] }
-datafusion = { version = "16.0.0", features = ["pyarrow", "avro"] }
-datafusion-expr = { version = "16.0.0" }
-datafusion-optimizer = { version = "16.0.0" }
-datafusion-common = { version = "16.0.0", features = ["pyarrow"] }
+datafusion = { git = "https://github.com/apache/arrow-datafusion", branch = "master", features = ["pyarrow", "avro"] }
+datafusion-expr = { git = "https://github.com/apache/arrow-datafusion", branch = "master" }
+datafusion-optimizer = { git = "https://github.com/apache/arrow-datafusion", branch = "master" }
+datafusion-common = { git = "https://github.com/apache/arrow-datafusion", branch = "master", features = ["pyarrow"] }
+datafusion-substrait = { git = "https://github.com/apache/arrow-datafusion", branch = "master" }
Review Comment:
Good point. Will change that now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] jdye64 commented on pull request #145: Substrait bindings
Posted by GitBox <gi...@apache.org>.
jdye64 commented on PR #145:
URL: https://github.com/apache/arrow-datafusion-python/pull/145#issuecomment-1397840332
I'm currently troubleshooting why github actions is not triggering
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org