You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/06/16 07:20:18 UTC

[GitHub] [hudi] yihua commented on a diff in pull request #5787: fix setup_demo.sh script to package jar inside docker folder

yihua commented on code in PR #5787:
URL: https://github.com/apache/hudi/pull/5787#discussion_r898773626


##########
docker/setup_demo.sh:
##########
@@ -19,6 +19,9 @@
 SCRIPT_PATH=$(cd `dirname $0`; pwd)
 HUDI_DEMO_ENV=$1
 WS_ROOT=`dirname $SCRIPT_PATH`
+cd hoodie/hadoop
+mvn clean package -DskipTests

Review Comment:
   Why do we need this here?  Should mvn build of hudi repo using `-Pintegration-tests` before running this script solve the problem?  It’s not a good idea to couple the docker setup with the build.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org