[GitHub] [submarine] yuanzac commented on a change in pull request #117: SUBMARINE-303. Submarine client submit job to submarine server by grpc.

[GitBox <gi...@apache.org>]

yuanzac commented on a change in pull request #117: SUBMARINE-303. Submarine client submit job to submarine server by grpc.
URL: https://github.com/apache/submarine/pull/117#discussion_r352459428
 
 

 ##########
 File path: dev-support/mini-submarine/conf/bootstrap.sh
 ##########
 @@ -36,6 +36,16 @@ for f in slaves core-site.xml hdfs-site.xml mapred-site.xml yarn-site.xml contai
   fi
 done
 
+# Copy submarine config
+for f in slaves submarine-site.xml submarine-env.sh; do
+  if [[ -e ${CONFIG_DIR}/$f ]]; then
+    cp ${CONFIG_DIR}/$f /opt/submarine-current/conf/$f
 
 Review comment:
   @pingsutw, Thanks for the review.
   /opt/submarine-current/conf/ has the latest submarine-site.xml and submarine-env.sh with default configuration. So we need to update them with the configuration suitable for mini-submarine.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org