You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by mc...@apache.org on 2013/03/25 20:55:49 UTC
svn commit: r1460863 -
/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/EvaluationPool.java
Author: mcucchiara
Date: Mon Mar 25 19:55:49 2013
New Revision: 1460863
URL: http://svn.apache.org/r1460863
Log:
Removed deprecated constructor, furthermore initialSize var was unused
Modified:
commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/EvaluationPool.java
Modified: commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/EvaluationPool.java
URL: http://svn.apache.org/viewvc/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/EvaluationPool.java?rev=1460863&r1=1460862&r2=1460863&view=diff
==============================================================================
--- commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/EvaluationPool.java (original)
+++ commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/EvaluationPool.java Mon Mar 25 19:55:49 2013
@@ -28,17 +28,6 @@ public final class EvaluationPool
{
public EvaluationPool()
{
- this( 0 );
- }
-
- /*
- * @deprecated evaluation-pool now relies on the jvm garbage collection
- * therefore providing an initialSize is unnecessary
- */
- public EvaluationPool( int initialSize )
- {
- super();
- // do not init object pooling
}
/**
Re: svn commit: r1460863 - /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/EvaluationPool.java
Posted by sebb <se...@gmail.com>.
On 25 March 2013 20:18, Emmanuel Bourg <eb...@apache.org> wrote:
> Le 25/03/2013 21:11, sebb a écrit :
>
>> -1
>>
>> If this is part of the public API, it will break compatibility.
>> The deprecated ctor does no harm, so please revert.
>
> But it hasn't been released yet, right? It's still time to clean up the API.
OK, in that case, my bad, I withdraw the -1.
To reduce compatibility issues later may I suggest:
- all mutable fields should be private
- all arrays should be private (final arrays still have mutable elements).
- prefer immutable classes - don't use setters unless absolutely necessary
- minimise access as far as possible.
- consider dividing the classes into public API and internal implementation
So long as it is clear to users which classes are not intended for
external use (even if public) then thos classes can be rewritten
without worrying about binary compat. If a 3rd party does use the
fobidden API, then they cannot complain if a future release breaks it.
> Emmanuel Bourg
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1460863 - /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/EvaluationPool.java
Posted by Emmanuel Bourg <eb...@apache.org>.
Le 25/03/2013 21:11, sebb a écrit :
> -1
>
> If this is part of the public API, it will break compatibility.
> The deprecated ctor does no harm, so please revert.
But it hasn't been released yet, right? It's still time to clean up the API.
Emmanuel Bourg
Re: svn commit: r1460863 - /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/EvaluationPool.java
Posted by Maurizio Cucchiara <mc...@apache.org>.
There is not yet a first release of OGNL, if there is a moment when
break the BC, that moment is now.
Twitter :http://www.twitter.com/m_cucchiara
G+ :https://plus.google.com/107903711540963855921
Linkedin :http://www.linkedin.com/in/mauriziocucchiara
VisualizeMe: http://vizualize.me/maurizio.cucchiara?r=maurizio.cucchiara
Maurizio Cucchiara
On 25 March 2013 21:11, sebb <se...@gmail.com> wrote:
> On 25 March 2013 19:55, <mc...@apache.org> wrote:
>> Author: mcucchiara
>> Date: Mon Mar 25 19:55:49 2013
>> New Revision: 1460863
>>
>> URL: http://svn.apache.org/r1460863
>> Log:
>> Removed deprecated constructor, furthermore initialSize var was unused
>
> -1
>
> If this is part of the public API, it will break compatibility.
> The deprecated ctor does no harm, so please revert.
>
>> Modified:
>> commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/EvaluationPool.java
>>
>> Modified: commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/EvaluationPool.java
>> URL: http://svn.apache.org/viewvc/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/EvaluationPool.java?rev=1460863&r1=1460862&r2=1460863&view=diff
>> ==============================================================================
>> --- commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/EvaluationPool.java (original)
>> +++ commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/EvaluationPool.java Mon Mar 25 19:55:49 2013
>> @@ -28,17 +28,6 @@ public final class EvaluationPool
>> {
>> public EvaluationPool()
>> {
>> - this( 0 );
>> - }
>> -
>> - /*
>> - * @deprecated evaluation-pool now relies on the jvm garbage collection
>> - * therefore providing an initialSize is unnecessary
>> - */
>> - public EvaluationPool( int initialSize )
>> - {
>> - super();
>> - // do not init object pooling
>> }
>>
>> /**
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1460863 - /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/EvaluationPool.java
Posted by sebb <se...@gmail.com>.
On 25 March 2013 19:55, <mc...@apache.org> wrote:
> Author: mcucchiara
> Date: Mon Mar 25 19:55:49 2013
> New Revision: 1460863
>
> URL: http://svn.apache.org/r1460863
> Log:
> Removed deprecated constructor, furthermore initialSize var was unused
-1
If this is part of the public API, it will break compatibility.
The deprecated ctor does no harm, so please revert.
> Modified:
> commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/EvaluationPool.java
>
> Modified: commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/EvaluationPool.java
> URL: http://svn.apache.org/viewvc/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/EvaluationPool.java?rev=1460863&r1=1460862&r2=1460863&view=diff
> ==============================================================================
> --- commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/EvaluationPool.java (original)
> +++ commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/EvaluationPool.java Mon Mar 25 19:55:49 2013
> @@ -28,17 +28,6 @@ public final class EvaluationPool
> {
> public EvaluationPool()
> {
> - this( 0 );
> - }
> -
> - /*
> - * @deprecated evaluation-pool now relies on the jvm garbage collection
> - * therefore providing an initialSize is unnecessary
> - */
> - public EvaluationPool( int initialSize )
> - {
> - super();
> - // do not init object pooling
> }
>
> /**
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org