[jira] [Commented] (CALCITE-3238) Support Time Zone suffix of DateTime types for SqlDataTypeSpec

["Julian Hyde (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-3238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905584#comment-16905584 ] 

Julian Hyde commented on CALCITE-3238:
--------------------------------------

Why do you allow WITH LOCAL TIME ZONE for all types, then validate? Why not just model it using grammar? It's generally a bad idea to do "validation" (and throw errors) in the parser.

> Support Time Zone suffix of DateTime types for SqlDataTypeSpec
> --------------------------------------------------------------
>
>                 Key: CALCITE-3238
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3238
>             Project: Calcite
>          Issue Type: Sub-task
>            Reporter: Danny Chan
>            Assignee: Danny Chan
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> This is the grammar copied from SQL-2011:
> {code:sql}
> <datetime type> ::=
>     DATE
>   | TIME [ <left paren> <time precision> <right paren> ] [ <with or without time zone> ]
>   | TIMESTAMP [ <left paren> <timestamp precision> <right paren> ]
>         [ <with or without time zone> ]
> <with or without time zone> ::=
>       WITH TIME ZONE
>     | WITHOUT TIME ZONE
> <time precision> ::=
>    <time fractional seconds precision>
> <timestamp precision> ::=
>    <time fractional seconds precision>
> <time fractional seconds precision> ::=
>    <unsigned integer>
> {code}
> We extend this grammar to support "with local time zone" definition:
> {code:sql}
> time(0) with local time zone
> timestamp(0) with local time zone
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)