[jira] [Commented] (SLING-8271) Improve AbstractResourceVisitor to allow to stop visiting child resources

["Konrad Windszus (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-8271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16765061#comment-16765061 ] 

Konrad Windszus commented on SLING-8271:
----------------------------------------

[~cziegeler] Since you added the code originally WDYT about this proposal? Do you have any good naming suggestion for that additional {{visit}} method? Java unfortunately doesn't allow us to name it {{visit}} as well.

> Improve AbstractResourceVisitor to allow to stop visiting child resources
> -------------------------------------------------------------------------
>
>                 Key: SLING-8271
>                 URL: https://issues.apache.org/jira/browse/SLING-8271
>             Project: Sling
>          Issue Type: Improvement
>          Components: API
>    Affects Versions: API 2.20.0
>            Reporter: Konrad Windszus
>            Priority: Major
>             Fix For: API 2.20.2
>
>
> Currently the AbstractResourceVisitor (https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/api/resource/AbstractResourceVisitor.java) completely decouples the {{visit}} method from the actual resource traversal. That means it is currently rather hard to programmatically add a break condition which should lead to no further descending into subresources.
> I propose to extend {{AbstractResourceVisitor}} by an additional visit method which is supposed to return a boolean value. Only if {{true}} is returned it will further descend into the children of the current resource. The default implementation should just return {{true}} to make this change backwards compatible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)