You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/09/14 07:38:03 UTC

[GitHub] [shardingsphere] ThanoshanMV opened a new pull request #12421: Support for LAST_VALUE in SQL parsing

ThanoshanMV opened a new pull request #12421:
URL: https://github.com/apache/shardingsphere/pull/12421


   Fixes #12370
   
   Hi @strongduanmu and @RaigorJiang. I've tried to fix that SQL parsing. Please check it.
   
   Changes proposed in this pull request:
   - Added `LAST_VALUE` in `customKeyword`.
   - Added test cases.
   - Then I tried to parse that SQL: 
   
   ![AfterFixingIssueInLastValue](https://user-images.githubusercontent.com/48581379/133214739-77ce917a-ed76-42e3-9543-e6a4f057ce81.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu merged pull request #12421: Support for LAST_VALUE in SQL parsing

Posted by GitBox <gi...@apache.org>.
strongduanmu merged pull request #12421:
URL: https://github.com/apache/shardingsphere/pull/12421


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu commented on pull request #12421: Support for LAST_VALUE in SQL parsing

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on pull request #12421:
URL: https://github.com/apache/shardingsphere/pull/12421#issuecomment-918903470


   @ThanoshanMV Great job, and i will review this pr.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org