You are viewing a plain text version of this content. The canonical link for it is here.
Posted to rpc-user@xml.apache.org by Daniel Rall <dl...@finemaltcoding.com> on 2002/08/07 22:13:09 UTC
Re: SimpleXmlRpcClient
Hi Mike. The SimpleXmlRpcClient class needs to be thoroughly
refactored to remove all the code which is duplicated by classes in
the root org.apache.xmlrpc package. Any patches accomplishing this
would be very appreciated.
Personally, I won't be touching that crufty old class with a ten foot
pole until this happens.
Mike Kline <mk...@cs.autometric.com> writes:
> I was wondering if the following had been reported for the SimpleXmlRpcClient class in the applet package.
>
> There are two System.out that are not wrapped in a if(debug) in the contained XmlRpcSupport class (execute method).
>
> Also, is the (fault) parameter ever set in the same method. Some guys we work with came up with the following code snippet to check for faults....
>
> class XmlSRpcSupport extends HandlerBase {
> .
> .
> .
> public Object execute (String method, Vector arguments) throws XmlRpcException, IOException {
> .
> .
> .
> con.setRequestProperty ("Content-Length", Integer.toString (request.length));
> con.setRequestProperty ("Content-Type", "text/xml");
> // con.connect ();
> OutputStream out = con.getOutputStream ();
> out.write (request);
> out.flush ();
> InputStream in = con.getInputStream ();
> parse (in);
> if (debug)
> System.out.println ("result = "+result);
> //// begin modification
> if (result instanceof java.util.Hashtable)
> {
> if (((Hashtable)result).size() > 0)
> {
> if (((Hashtable)result).get("faultCode") != null)
> {
> fault = true;
> }
> }
> }
> /// end modification
>
> If these are relevant when might I be able to get a release with the fixes.
>
> --
> Mike Kline
>
--
Daniel Rall <dl...@finemaltcoding.com>
Re: Xmlrpc with jdk 1.4
Posted by Paul Oehler <po...@umich.edu>.
I've been using it for some time with 1.4, with no problems.
----- Original Message -----
From: "Mike Kline" <mk...@cs.autometric.com>
To: <rp...@xml.apache.org>
Sent: Thursday, August 08, 2002 2:44 PM
Subject: Xmlrpc with jdk 1.4
> Have there been any problems related to xmlrpc and jdk 1.4???
>
> Mike
>
> Daniel Rall wrote:
> >
> > Sounds great Mike, looking forward to it.
> >
> > Mike Kline <mk...@cs.autometric.com> writes:
> >
> > > Dan,
> > >
> > > I might have time next week to take a look at the whole class. Then
> > > I'll email you any changes. Thanks for responding.
> > >
> > > Daniel Rall wrote:
> > > >
> > > > Hi Mike. The SimpleXmlRpcClient class needs to be thoroughly
> > > > refactored to remove all the code which is duplicated by classes in
> > > > the root org.apache.xmlrpc package. Any patches accomplishing this
> > > > would be very appreciated.
> > > >
> > > > Personally, I won't be touching that crufty old class with a ten
foot
> > > > pole until this happens.
>
> --
> Mike Kline
> Senior Software Engineer
> Boeing-Autometric, Inc.
> 1330 Inverness Drive
> Colorado Springs, CO 80921
>
> (719) 572-8123
> mkline@autometric.com
> Michael.Kline@boeing.com
Re: Xmlrpc with jdk 1.4
Posted by Paul Oehler <po...@umich.edu>.
I've been using it for some time with 1.4, with no problems.
----- Original Message -----
From: "Mike Kline" <mk...@cs.autometric.com>
To: <rp...@xml.apache.org>
Sent: Thursday, August 08, 2002 2:44 PM
Subject: Xmlrpc with jdk 1.4
> Have there been any problems related to xmlrpc and jdk 1.4???
>
> Mike
>
> Daniel Rall wrote:
> >
> > Sounds great Mike, looking forward to it.
> >
> > Mike Kline <mk...@cs.autometric.com> writes:
> >
> > > Dan,
> > >
> > > I might have time next week to take a look at the whole class. Then
> > > I'll email you any changes. Thanks for responding.
> > >
> > > Daniel Rall wrote:
> > > >
> > > > Hi Mike. The SimpleXmlRpcClient class needs to be thoroughly
> > > > refactored to remove all the code which is duplicated by classes in
> > > > the root org.apache.xmlrpc package. Any patches accomplishing this
> > > > would be very appreciated.
> > > >
> > > > Personally, I won't be touching that crufty old class with a ten
foot
> > > > pole until this happens.
>
> --
> Mike Kline
> Senior Software Engineer
> Boeing-Autometric, Inc.
> 1330 Inverness Drive
> Colorado Springs, CO 80921
>
> (719) 572-8123
> mkline@autometric.com
> Michael.Kline@boeing.com
Xmlrpc with jdk 1.4
Posted by Mike Kline <mk...@cs.autometric.com>.
Have there been any problems related to xmlrpc and jdk 1.4???
Mike
Daniel Rall wrote:
>
> Sounds great Mike, looking forward to it.
>
> Mike Kline <mk...@cs.autometric.com> writes:
>
> > Dan,
> >
> > I might have time next week to take a look at the whole class. Then
> > I'll email you any changes. Thanks for responding.
> >
> > Daniel Rall wrote:
> > >
> > > Hi Mike. The SimpleXmlRpcClient class needs to be thoroughly
> > > refactored to remove all the code which is duplicated by classes in
> > > the root org.apache.xmlrpc package. Any patches accomplishing this
> > > would be very appreciated.
> > >
> > > Personally, I won't be touching that crufty old class with a ten foot
> > > pole until this happens.
--
Mike Kline
Senior Software Engineer
Boeing-Autometric, Inc.
1330 Inverness Drive
Colorado Springs, CO 80921
(719) 572-8123
mkline@autometric.com
Michael.Kline@boeing.com
Xmlrpc with jdk 1.4
Posted by Mike Kline <mk...@cs.autometric.com>.
Have there been any problems related to xmlrpc and jdk 1.4???
Mike
Daniel Rall wrote:
>
> Sounds great Mike, looking forward to it.
>
> Mike Kline <mk...@cs.autometric.com> writes:
>
> > Dan,
> >
> > I might have time next week to take a look at the whole class. Then
> > I'll email you any changes. Thanks for responding.
> >
> > Daniel Rall wrote:
> > >
> > > Hi Mike. The SimpleXmlRpcClient class needs to be thoroughly
> > > refactored to remove all the code which is duplicated by classes in
> > > the root org.apache.xmlrpc package. Any patches accomplishing this
> > > would be very appreciated.
> > >
> > > Personally, I won't be touching that crufty old class with a ten foot
> > > pole until this happens.
--
Mike Kline
Senior Software Engineer
Boeing-Autometric, Inc.
1330 Inverness Drive
Colorado Springs, CO 80921
(719) 572-8123
mkline@autometric.com
Michael.Kline@boeing.com
Re: SimpleXmlRpcClient
Posted by Daniel Rall <dl...@finemaltcoding.com>.
Sounds great Mike, looking forward to it.
Mike Kline <mk...@cs.autometric.com> writes:
> Dan,
>
> I might have time next week to take a look at the whole class. Then
> I'll email you any changes. Thanks for responding.
>
> Daniel Rall wrote:
> >
> > Hi Mike. The SimpleXmlRpcClient class needs to be thoroughly
> > refactored to remove all the code which is duplicated by classes in
> > the root org.apache.xmlrpc package. Any patches accomplishing this
> > would be very appreciated.
> >
> > Personally, I won't be touching that crufty old class with a ten foot
> > pole until this happens.
Re: SimpleXmlRpcClient
Posted by Daniel Rall <dl...@finemaltcoding.com>.
Sounds great Mike, looking forward to it.
Mike Kline <mk...@cs.autometric.com> writes:
> Dan,
>
> I might have time next week to take a look at the whole class. Then
> I'll email you any changes. Thanks for responding.
>
> Daniel Rall wrote:
> >
> > Hi Mike. The SimpleXmlRpcClient class needs to be thoroughly
> > refactored to remove all the code which is duplicated by classes in
> > the root org.apache.xmlrpc package. Any patches accomplishing this
> > would be very appreciated.
> >
> > Personally, I won't be touching that crufty old class with a ten foot
> > pole until this happens.
Re: SimpleXmlRpcClient
Posted by Mike Kline <mk...@cs.autometric.com>.
Dan,
I might have time next week to take a look at the whole class. Then I'll email you any changes. Thanks for responding.
Mike K.
Daniel Rall wrote:
>
> Hi Mike. The SimpleXmlRpcClient class needs to be thoroughly
> refactored to remove all the code which is duplicated by classes in
> the root org.apache.xmlrpc package. Any patches accomplishing this
> would be very appreciated.
>
> Personally, I won't be touching that crufty old class with a ten foot
> pole until this happens.
>
> Mike Kline <mk...@cs.autometric.com> writes:
>
> > I was wondering if the following had been reported for the SimpleXmlRpcClient class in the applet package.
> >
> > There are two System.out that are not wrapped in a if(debug) in the contained XmlRpcSupport class (execute method).
> >
> > Also, is the (fault) parameter ever set in the same method. Some guys we work with came up with the following code snippet to check for faults....
> >
> > class XmlSRpcSupport extends HandlerBase {
> > .
> > .
> > .
> > public Object execute (String method, Vector arguments) throws XmlRpcException, IOException {
> > .
> > .
> > .
> > con.setRequestProperty ("Content-Length", Integer.toString (request.length));
> > con.setRequestProperty ("Content-Type", "text/xml");
> > // con.connect ();
> > OutputStream out = con.getOutputStream ();
> > out.write (request);
> > out.flush ();
> > InputStream in = con.getInputStream ();
> > parse (in);
> > if (debug)
> > System.out.println ("result = "+result);
> > //// begin modification
> > if (result instanceof java.util.Hashtable)
> > {
> > if (((Hashtable)result).size() > 0)
> > {
> > if (((Hashtable)result).get("faultCode") != null)
> > {
> > fault = true;
> > }
> > }
> > }
> > /// end modification
> >
> > If these are relevant when might I be able to get a release with the fixes.
> >
> > --
> > Mike Kline
> >
>
> --
>
> Daniel Rall <dl...@finemaltcoding.com>
--
Mike Kline
Senior Software Engineer
Boeing-Autometric, Inc.
1330 Inverness Drive
Colorado Springs, CO 80921
(719) 572-8123
mkline@autometric.com
Michael.Kline@boeing.com
Re: SimpleXmlRpcClient
Posted by Mike Kline <mk...@cs.autometric.com>.
Dan,
I might have time next week to take a look at the whole class. Then I'll email you any changes. Thanks for responding.
Mike K.
Daniel Rall wrote:
>
> Hi Mike. The SimpleXmlRpcClient class needs to be thoroughly
> refactored to remove all the code which is duplicated by classes in
> the root org.apache.xmlrpc package. Any patches accomplishing this
> would be very appreciated.
>
> Personally, I won't be touching that crufty old class with a ten foot
> pole until this happens.
>
> Mike Kline <mk...@cs.autometric.com> writes:
>
> > I was wondering if the following had been reported for the SimpleXmlRpcClient class in the applet package.
> >
> > There are two System.out that are not wrapped in a if(debug) in the contained XmlRpcSupport class (execute method).
> >
> > Also, is the (fault) parameter ever set in the same method. Some guys we work with came up with the following code snippet to check for faults....
> >
> > class XmlSRpcSupport extends HandlerBase {
> > .
> > .
> > .
> > public Object execute (String method, Vector arguments) throws XmlRpcException, IOException {
> > .
> > .
> > .
> > con.setRequestProperty ("Content-Length", Integer.toString (request.length));
> > con.setRequestProperty ("Content-Type", "text/xml");
> > // con.connect ();
> > OutputStream out = con.getOutputStream ();
> > out.write (request);
> > out.flush ();
> > InputStream in = con.getInputStream ();
> > parse (in);
> > if (debug)
> > System.out.println ("result = "+result);
> > //// begin modification
> > if (result instanceof java.util.Hashtable)
> > {
> > if (((Hashtable)result).size() > 0)
> > {
> > if (((Hashtable)result).get("faultCode") != null)
> > {
> > fault = true;
> > }
> > }
> > }
> > /// end modification
> >
> > If these are relevant when might I be able to get a release with the fixes.
> >
> > --
> > Mike Kline
> >
>
> --
>
> Daniel Rall <dl...@finemaltcoding.com>
--
Mike Kline
Senior Software Engineer
Boeing-Autometric, Inc.
1330 Inverness Drive
Colorado Springs, CO 80921
(719) 572-8123
mkline@autometric.com
Michael.Kline@boeing.com