Re: [PR] Add support to RBD erasure code pools [cloudstack]

["BryanMLima (via GitHub)" <gi...@apache.org>]

BryanMLima commented on code in PR #9808:
URL: https://github.com/apache/cloudstack/pull/9808#discussion_r1856670829


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java:
##########
@@ -868,7 +868,7 @@ public KVMPhysicalDisk createPhysicalDisk(String name, KVMStoragePool pool,
 
         StoragePoolType poolType = pool.getType();
         if (poolType.equals(StoragePoolType.RBD)) {
-            return createPhysicalDiskByLibVirt(name, pool, PhysicalDiskFormat.RAW, provisioningType, size);
+            return createPhysicalDiskByQemuImg(name, pool, PhysicalDiskFormat.RAW, provisioningType, size, passphrase);

Review Comment:
   Sure, I added a conditional inside this method to maintain the current behaviour.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org