You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/04/21 18:18:29 UTC
[GitHub] [ignite] ptupitsyn opened a new pull request #7710: IGNITE-12918 Fix Travis config: separate Java jobs
ptupitsyn opened a new pull request #7710:
URL: https://github.com/apache/ignite/pull/7710
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Mmuzaf commented on a change in pull request #7710: IGNITE-12918 Fix Travis config: separate Java jobs
Posted by GitBox <gi...@apache.org>.
Mmuzaf commented on a change in pull request #7710:
URL: https://github.com/apache/ignite/pull/7710#discussion_r412777031
##########
File path: .travis.yml
##########
@@ -23,26 +23,32 @@ matrix:
- echo $JVM_EXTRA_ARGS
- echo $JDK_PROFILES
script: mvn package -Pall-java,licenses,lgpl,checkstyle,examples $JDK_PROFILES -DskipTests -Dmaven.javadoc.skip=true -B -V
-
- jobs:
- include:
- - jdk: openjdk8
- env:
- - JDK_PROFILES='-Pall-scala,scala'
- - jdk: openjdk11
- # ignite-scalar module currently doesn't build under jdk11
- env:
- - JDK_PROFILES='-P!spark-2.4,!spark,!scala'
- before_script:
- - |
- export JVM_EXTRA_ARGS='--illegal-access=permit
- --add-exports=java.base/jdk.internal.misc=ALL-UNNAMED
- --add-exports=java.base/sun.nio.ch=ALL-UNNAMED
- --add-exports=java.management/com.sun.jmx.mbeanserver=ALL-UNNAMED
- --add-exports=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED
- --add-exports=java.base/sun.reflect.generics.reflectiveObjects=ALL-UNNAMED
- -Djdk.tls.client.protocols=TLSv1.2'
-
+ jdk: openjdk8
+ env:
+ - JDK_PROFILES='-Pall-scala,scala'
+ before_cache: rm -rfv $HOME/.m2/repository/org/apache/ignite
+ cache: {directories: [$HOME/.m2/repository]}
+
+ - language: java
+ os: linux
+ dist: trusty
+ install: skip
+ before_script:
+ - echo $JVM_EXTRA_ARGS
+ - echo $JDK_PROFILES
+ - |
+ export JVM_EXTRA_ARGS='--illegal-access=permit
+ --add-exports=java.base/jdk.internal.misc=ALL-UNNAMED
+ --add-exports=java.base/sun.nio.ch=ALL-UNNAMED
+ --add-exports=java.management/com.sun.jmx.mbeanserver=ALL-UNNAMED
+ --add-exports=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED
+ --add-exports=java.base/sun.reflect.generics.reflectiveObjects=ALL-UNNAMED
+ -Djdk.tls.client.protocols=TLSv1.2'
+ script: mvn package -Pall-java,licenses,lgpl,checkstyle,examples $JDK_PROFILES -DskipTests -Dmaven.javadoc.skip=true -B -V
+ jdk: openjdk11
+ # ignite-scalar module currently doesn't build under jdk11
+ env:
+ - JDK_PROFILES='-P!spark-2.4,!spark,!scala'
Review comment:
I think `JDK_PROFILES` is not needed anymore since it can be directly set to an appropriate JDK profile.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn removed a comment on issue #7710: IGNITE-12918 Fix Travis config: separate Java jobs
Posted by GitBox <gi...@apache.org>.
ptupitsyn removed a comment on issue #7710:
URL: https://github.com/apache/ignite/pull/7710#issuecomment-617673590
Messed up the branch, had to create a new PR: #7712
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Mmuzaf commented on a change in pull request #7710: IGNITE-12918 Fix Travis config: separate Java jobs
Posted by GitBox <gi...@apache.org>.
Mmuzaf commented on a change in pull request #7710:
URL: https://github.com/apache/ignite/pull/7710#discussion_r412824677
##########
File path: .travis.yml
##########
@@ -23,26 +23,32 @@ matrix:
- echo $JVM_EXTRA_ARGS
- echo $JDK_PROFILES
script: mvn package -Pall-java,licenses,lgpl,checkstyle,examples $JDK_PROFILES -DskipTests -Dmaven.javadoc.skip=true -B -V
-
- jobs:
- include:
- - jdk: openjdk8
- env:
- - JDK_PROFILES='-Pall-scala,scala'
- - jdk: openjdk11
- # ignite-scalar module currently doesn't build under jdk11
- env:
- - JDK_PROFILES='-P!spark-2.4,!spark,!scala'
- before_script:
- - |
- export JVM_EXTRA_ARGS='--illegal-access=permit
- --add-exports=java.base/jdk.internal.misc=ALL-UNNAMED
- --add-exports=java.base/sun.nio.ch=ALL-UNNAMED
- --add-exports=java.management/com.sun.jmx.mbeanserver=ALL-UNNAMED
- --add-exports=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED
- --add-exports=java.base/sun.reflect.generics.reflectiveObjects=ALL-UNNAMED
- -Djdk.tls.client.protocols=TLSv1.2'
-
+ jdk: openjdk8
+ env:
+ - JDK_PROFILES='-Pall-scala,scala'
+ before_cache: rm -rfv $HOME/.m2/repository/org/apache/ignite
+ cache: {directories: [$HOME/.m2/repository]}
+
+ - language: java
+ os: linux
+ dist: trusty
+ install: skip
+ before_script:
+ - echo $JVM_EXTRA_ARGS
+ - echo $JDK_PROFILES
+ - |
+ export JVM_EXTRA_ARGS='--illegal-access=permit
+ --add-exports=java.base/jdk.internal.misc=ALL-UNNAMED
+ --add-exports=java.base/sun.nio.ch=ALL-UNNAMED
+ --add-exports=java.management/com.sun.jmx.mbeanserver=ALL-UNNAMED
+ --add-exports=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED
+ --add-exports=java.base/sun.reflect.generics.reflectiveObjects=ALL-UNNAMED
+ -Djdk.tls.client.protocols=TLSv1.2'
+ script: mvn package -Pall-java,licenses,lgpl,checkstyle,examples $JDK_PROFILES -DskipTests -Dmaven.javadoc.skip=true -B -V
+ jdk: openjdk11
+ # ignite-scalar module currently doesn't build under jdk11
+ env:
+ - JDK_PROFILES='-P!spark-2.4,!spark,!scala'
Review comment:
@ptupitsyn yes, exactly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn commented on a change in pull request #7710: IGNITE-12918 Fix Travis config: separate Java jobs
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on a change in pull request #7710:
URL: https://github.com/apache/ignite/pull/7710#discussion_r412800801
##########
File path: .travis.yml
##########
@@ -23,26 +23,32 @@ matrix:
- echo $JVM_EXTRA_ARGS
- echo $JDK_PROFILES
script: mvn package -Pall-java,licenses,lgpl,checkstyle,examples $JDK_PROFILES -DskipTests -Dmaven.javadoc.skip=true -B -V
-
- jobs:
- include:
- - jdk: openjdk8
- env:
- - JDK_PROFILES='-Pall-scala,scala'
- - jdk: openjdk11
- # ignite-scalar module currently doesn't build under jdk11
- env:
- - JDK_PROFILES='-P!spark-2.4,!spark,!scala'
- before_script:
- - |
- export JVM_EXTRA_ARGS='--illegal-access=permit
- --add-exports=java.base/jdk.internal.misc=ALL-UNNAMED
- --add-exports=java.base/sun.nio.ch=ALL-UNNAMED
- --add-exports=java.management/com.sun.jmx.mbeanserver=ALL-UNNAMED
- --add-exports=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED
- --add-exports=java.base/sun.reflect.generics.reflectiveObjects=ALL-UNNAMED
- -Djdk.tls.client.protocols=TLSv1.2'
-
+ jdk: openjdk8
+ env:
+ - JDK_PROFILES='-Pall-scala,scala'
+ before_cache: rm -rfv $HOME/.m2/repository/org/apache/ignite
+ cache: {directories: [$HOME/.m2/repository]}
+
+ - language: java
+ os: linux
+ dist: trusty
+ install: skip
+ before_script:
+ - echo $JVM_EXTRA_ARGS
+ - echo $JDK_PROFILES
+ - |
+ export JVM_EXTRA_ARGS='--illegal-access=permit
+ --add-exports=java.base/jdk.internal.misc=ALL-UNNAMED
+ --add-exports=java.base/sun.nio.ch=ALL-UNNAMED
+ --add-exports=java.management/com.sun.jmx.mbeanserver=ALL-UNNAMED
+ --add-exports=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED
+ --add-exports=java.base/sun.reflect.generics.reflectiveObjects=ALL-UNNAMED
+ -Djdk.tls.client.protocols=TLSv1.2'
+ script: mvn package -Pall-java,licenses,lgpl,checkstyle,examples $JDK_PROFILES -DskipTests -Dmaven.javadoc.skip=true -B -V
+ jdk: openjdk11
+ # ignite-scalar module currently doesn't build under jdk11
+ env:
+ - JDK_PROFILES='-P!spark-2.4,!spark,!scala'
Review comment:
@Mmuzaf do you mean I should inline this env var, put the profiles directly to `script`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn commented on issue #7710: IGNITE-12918 Fix Travis config: separate Java jobs
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on issue #7710:
URL: https://github.com/apache/ignite/pull/7710#issuecomment-617675658
PR autoclosed due to a mistakenly deleted branch. New one: #7713
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn commented on issue #7710: IGNITE-12918 Fix Travis config: separate Java jobs
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on issue #7710:
URL: https://github.com/apache/ignite/pull/7710#issuecomment-617673590
Messed up the branch, had to create a new PR: #7712
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org