[GitHub] [samza] mynameborat commented on a change in pull request #1299: SAMZA-2477: JobModel isn't updated with latest "task.inputs" if enabled regex topic rewriter

[GitBox <gi...@apache.org>]

mynameborat commented on a change in pull request #1299: SAMZA-2477: JobModel isn't updated with latest "task.inputs" if enabled regex topic rewriter
URL: https://github.com/apache/samza/pull/1299#discussion_r393210621
 
 

 ##########
 File path: samza-core/src/main/scala/org/apache/samza/coordinator/JobModelManager.scala
 ##########
 @@ -353,20 +357,23 @@ object JobModelManager extends Logging {
                    changeLogPartitionMapping: util.Map[TaskName, Integer],
                    streamMetadataCache: StreamMetadataCache,
                    grouperMetadata: GrouperMetadata): JobModel = {
-    val taskConfig = new TaskConfig(config)
+    // refresh config if enabled regex topic rewriter
+    val newConfig = refreshConfigByRegexTopicRewriter(config)
 
 Review comment:
   I'd recommend renaming the method parameter to `originalConfig` and rename `newConfig` to `config`. It minimizes the changes in this PR and also removes unnecessary redirections in commit log which are just renames.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services