[GitHub] spark pull request: [SPARK-10051][SPARKR] Support collecting data ...

[davies <gi...@git.apache.org>]

Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8794#discussion_r40967389
  
    --- Diff: R/pkg/R/schema.R ---
    @@ -157,6 +157,30 @@ checkType <- function(type) {
                     checkType(valueType)
                     return()
                   }
    +            },
    +            s = {
    +              # Struct type
    +              m <- regexec("^struct<(.+)>$", type)
    --- End diff --
    
    We already use JSON to serialize the schema, why not use it here? (It was, but deleted later, you could find it in the history)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org