You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@age.apache.org by "MuhammadTahaNaveed (via GitHub)" <gi...@apache.org> on 2023/01/23 19:43:42 UTC

[GitHub] [age] MuhammadTahaNaveed opened a new pull request, #587: Implement CI test for python driver

MuhammadTahaNaveed opened a new pull request, #587:
URL: https://github.com/apache/age/pull/587

   ### What I did
   - Implemented a CI workflow for python driver that ensures that any PR/commit that modifies files under age/drivers/python is passing the tests.
   - Moved docker-compose.yaml file in age/drivers/golang to age/drivers, because this is required to instantiate a postgres instance needed for unit testing.
   - Modified host address of connection params to localhost in 'test_age_py.py' to connect to postgres instance running in docker container.
   
   ### Additional Context
   This workflow will only run if their is a modification in files under age/drivers/python.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [age] MuhammadTahaNaveed commented on pull request #587: Implement CI test for python driver

Posted by "MuhammadTahaNaveed (via GitHub)" <gi...@apache.org>.
MuhammadTahaNaveed commented on PR #587:
URL: https://github.com/apache/age/pull/587#issuecomment-1400971315

   Ok 😅. Is their any forum or something like that where Apache informs about these things ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [age] jrgemignani commented on pull request #587: Implement CI test for python driver

Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani commented on PR #587:
URL: https://github.com/apache/age/pull/587#issuecomment-1400929068

   @MuhammadTahaNaveed While I am all for these automated tests, I need to put a hold on them for the moment. 
   
   Apache org is moving away from Travis CI and we aren't sure of what direction we need to go with these tests - both current and new ones. That is, do they have another CI product they want us to use in place of Travis or can we still continue to use Travis.
   
   If you would like to look into that, that would be really helpful and appreciated


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [age] jrgemignani commented on pull request #587: Implement CI test for python driver

Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani commented on PR #587:
URL: https://github.com/apache/age/pull/587#issuecomment-1411213985

   > Ok 😅. Is their any forum or something like that where Apache informs about these things ? Btw, this workflow is not using travis, it is using github actions.
   
   They informed us via email. Our options are Github actions or Jenkins. Jenkins supports ARM whereas Github actions doesn't.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [age] jrgemignani merged pull request #587: Implement CI test for python driver

Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani merged PR #587:
URL: https://github.com/apache/age/pull/587


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org