You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mario-renau-alstom (via GitHub)" <gi...@apache.org> on 2023/08/01 08:13:25 UTC
[GitHub] [incubator-pekko-samples] mario-renau-alstom opened a new pull request, #55: Fixed command alias
mario-renau-alstom opened a new pull request, #55:
URL: https://github.com/apache/incubator-pekko-samples/pull/55
Command alias must include module name, so instead of:
// Startup aliases for the first two seed nodes and a third, more can be started.
addCommandAlias("sharding1", "**runMain** sample.killrweather.KillrWeather 7345")
addCommandAlias("sharding2", "**runMain** sample.killrweather.KillrWeather 7355")
addCommandAlias("sharding3", "**runMain** sample.killrweather.KillrWeather 0")
They must be:
// Startup aliases for the first two seed nodes and a third, more can be started.
addCommandAlias("sharding1", "**killrweather/runMain** sample.killrweather.KillrWeather 7345")
addCommandAlias("sharding2", "**killrweather/runMain** sample.killrweather.KillrWeather 7355")
addCommandAlias("sharding3", "**killrweather/runMain** sample.killrweather.KillrWeather 0")
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-samples] pjfanning commented on a diff in pull request #55: Fixed command alias
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #55:
URL: https://github.com/apache/incubator-pekko-samples/pull/55#discussion_r1280271272
##########
pekko-sample-sharding-scala/build.sbt:
##########
@@ -60,6 +60,6 @@ lazy val `killrweather-fog` = project
"ch.qos.logback" % "logback-classic" % logbackVersion))
// Startup aliases for the first two seed nodes and a third, more can be started.
-addCommandAlias("sharding1", "runMain sample.killrweather.KillrWeather 7345")
-addCommandAlias("sharding2", "runMain sample.killrweather.KillrWeather 7355")
-addCommandAlias("sharding3", "runMain sample.killrweather.KillrWeather 0")
+addCommandAlias("sharding1", "killrweather/runMain sample.killrweather.KillrWeather 7345")
+addCommandAlias("sharding2", "killrweather/runMain sample.killrweather.KillrWeather 7355")
+addCommandAlias("sharding3", "killrweather/runMain sample.killrweather.KillrWeather 0")
Review Comment:
could you add a blank line at the end of this file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-samples] pjfanning merged pull request #55: Fixed command alias
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #55:
URL: https://github.com/apache/incubator-pekko-samples/pull/55
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-samples] mario-renau-alstom commented on a diff in pull request #55: Fixed command alias
Posted by "mario-renau-alstom (via GitHub)" <gi...@apache.org>.
mario-renau-alstom commented on code in PR #55:
URL: https://github.com/apache/incubator-pekko-samples/pull/55#discussion_r1280287389
##########
pekko-sample-sharding-scala/build.sbt:
##########
@@ -60,6 +60,6 @@ lazy val `killrweather-fog` = project
"ch.qos.logback" % "logback-classic" % logbackVersion))
// Startup aliases for the first two seed nodes and a third, more can be started.
-addCommandAlias("sharding1", "runMain sample.killrweather.KillrWeather 7345")
-addCommandAlias("sharding2", "runMain sample.killrweather.KillrWeather 7355")
-addCommandAlias("sharding3", "runMain sample.killrweather.KillrWeather 0")
+addCommandAlias("sharding1", "killrweather/runMain sample.killrweather.KillrWeather 7345")
+addCommandAlias("sharding2", "killrweather/runMain sample.killrweather.KillrWeather 7355")
+addCommandAlias("sharding3", "killrweather/runMain sample.killrweather.KillrWeather 0")
Review Comment:
Yes, done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org