You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Mukund Madhugiri (JIRA)" <ji...@apache.org> on 2008/03/03 19:16:50 UTC
[jira] Created: (HADOOP-2927) Unit test fails on Windows:
org.apache.hadoop.fs.TestDU.testDU
Unit test fails on Windows: org.apache.hadoop.fs.TestDU.testDU
--------------------------------------------------------------
Key: HADOOP-2927
URL: https://issues.apache.org/jira/browse/HADOOP-2927
Project: Hadoop Core
Issue Type: Bug
Components: fs
Affects Versions: 0.17.0
Reporter: Mukund Madhugiri
Assignee: Robert Chansler
Priority: Blocker
Fix For: 0.17.0
Unit test fails on Windows: org.apache.hadoop.fs.TestDU.testDU
Here is the output from the test: org.apache.hadoop.fs.TestDU.testDU:
junit.framework.AssertionFailedError: expected:<2048> but was:<4096>
at org.apache.hadoop.fs.TestDU.testDU(TestDU.java:82)
The failure points to the new test code in TestDU.java that just went in as part of HADOOP-2845
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-2927) Unit test fails on Windows:
org.apache.hadoop.fs.TestDU.testDU
Posted by "Robert Chansler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Chansler reassigned HADOOP-2927:
---------------------------------------
Assignee: Konstantin Shvachko (was: Robert Chansler)
> Unit test fails on Windows: org.apache.hadoop.fs.TestDU.testDU
> --------------------------------------------------------------
>
> Key: HADOOP-2927
> URL: https://issues.apache.org/jira/browse/HADOOP-2927
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.17.0
> Reporter: Mukund Madhugiri
> Assignee: Konstantin Shvachko
> Priority: Blocker
> Fix For: 0.17.0
>
>
> Unit test fails on Windows: org.apache.hadoop.fs.TestDU.testDU
> Here is the output from the test: org.apache.hadoop.fs.TestDU.testDU:
> junit.framework.AssertionFailedError: expected:<2048> but was:<4096>
> at org.apache.hadoop.fs.TestDU.testDU(TestDU.java:82)
> The failure points to the new test code in TestDU.java that just went in as part of HADOOP-2845
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2927) Unit test fails on Windows:
org.apache.hadoop.fs.TestDU.testDU
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585975#action_12585975 ]
Hudson commented on HADOOP-2927:
--------------------------------
Integrated in Hadoop-trunk #451 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/451/])
> Unit test fails on Windows: org.apache.hadoop.fs.TestDU.testDU
> --------------------------------------------------------------
>
> Key: HADOOP-2927
> URL: https://issues.apache.org/jira/browse/HADOOP-2927
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.17.0
> Reporter: Mukund Madhugiri
> Assignee: Konstantin Shvachko
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: testDU.patch
>
>
> Unit test fails on Windows: org.apache.hadoop.fs.TestDU.testDU
> Here is the output from the test: org.apache.hadoop.fs.TestDU.testDU:
> junit.framework.AssertionFailedError: expected:<2048> but was:<4096>
> at org.apache.hadoop.fs.TestDU.testDU(TestDU.java:82)
> The failure points to the new test code in TestDU.java that just went in as part of HADOOP-2845
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2927) Unit test fails on Windows:
org.apache.hadoop.fs.TestDU.testDU
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585392#action_12585392 ]
Nigel Daley commented on HADOOP-2927:
-------------------------------------
I verified this patch fixes the test on Windows and still runs fine on Linux. I also ran the test-patch target with these results:
[exec] +1 overall.
[exec]
[exec] @author +1. The patch does not contain any @author tags.
[exec]
[exec] tests included +1. The patch appears to include 3 new or modified tests.
[exec]
[exec] javadoc +1. The javadoc tool did not generate any warning messages.
[exec]
[exec] javac +1. The applied patch does not generate any new javac compiler warnings.
[exec]
[exec] findbugs +1. The patch does not introduce any new Findbugs warnings.
I will commit the patch now.
> Unit test fails on Windows: org.apache.hadoop.fs.TestDU.testDU
> --------------------------------------------------------------
>
> Key: HADOOP-2927
> URL: https://issues.apache.org/jira/browse/HADOOP-2927
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.17.0
> Reporter: Mukund Madhugiri
> Assignee: Konstantin Shvachko
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: testDU.patch
>
>
> Unit test fails on Windows: org.apache.hadoop.fs.TestDU.testDU
> Here is the output from the test: org.apache.hadoop.fs.TestDU.testDU:
> junit.framework.AssertionFailedError: expected:<2048> but was:<4096>
> at org.apache.hadoop.fs.TestDU.testDU(TestDU.java:82)
> The failure points to the new test code in TestDU.java that just went in as part of HADOOP-2845
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2927) Unit test fails on Windows:
org.apache.hadoop.fs.TestDU.testDU
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Shvachko updated HADOOP-2927:
----------------------------------------
Status: Patch Available (was: Open)
> Unit test fails on Windows: org.apache.hadoop.fs.TestDU.testDU
> --------------------------------------------------------------
>
> Key: HADOOP-2927
> URL: https://issues.apache.org/jira/browse/HADOOP-2927
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.17.0
> Reporter: Mukund Madhugiri
> Assignee: Konstantin Shvachko
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: testDU.patch
>
>
> Unit test fails on Windows: org.apache.hadoop.fs.TestDU.testDU
> Here is the output from the test: org.apache.hadoop.fs.TestDU.testDU:
> junit.framework.AssertionFailedError: expected:<2048> but was:<4096>
> at org.apache.hadoop.fs.TestDU.testDU(TestDU.java:82)
> The failure points to the new test code in TestDU.java that just went in as part of HADOOP-2845
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2927) Unit test fails on Windows:
org.apache.hadoop.fs.TestDU.testDU
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nigel Daley updated HADOOP-2927:
--------------------------------
Hadoop Flags: [Reviewed]
+1 code review
> Unit test fails on Windows: org.apache.hadoop.fs.TestDU.testDU
> --------------------------------------------------------------
>
> Key: HADOOP-2927
> URL: https://issues.apache.org/jira/browse/HADOOP-2927
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.17.0
> Reporter: Mukund Madhugiri
> Assignee: Konstantin Shvachko
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: testDU.patch
>
>
> Unit test fails on Windows: org.apache.hadoop.fs.TestDU.testDU
> Here is the output from the test: org.apache.hadoop.fs.TestDU.testDU:
> junit.framework.AssertionFailedError: expected:<2048> but was:<4096>
> at org.apache.hadoop.fs.TestDU.testDU(TestDU.java:82)
> The failure points to the new test code in TestDU.java that just went in as part of HADOOP-2845
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2927) Unit test fails on Windows:
org.apache.hadoop.fs.TestDU.testDU
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nigel Daley updated HADOOP-2927:
--------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this. Thanks Konstantin!
> Unit test fails on Windows: org.apache.hadoop.fs.TestDU.testDU
> --------------------------------------------------------------
>
> Key: HADOOP-2927
> URL: https://issues.apache.org/jira/browse/HADOOP-2927
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.17.0
> Reporter: Mukund Madhugiri
> Assignee: Konstantin Shvachko
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: testDU.patch
>
>
> Unit test fails on Windows: org.apache.hadoop.fs.TestDU.testDU
> Here is the output from the test: org.apache.hadoop.fs.TestDU.testDU:
> junit.framework.AssertionFailedError: expected:<2048> but was:<4096>
> at org.apache.hadoop.fs.TestDU.testDU(TestDU.java:82)
> The failure points to the new test code in TestDU.java that just went in as part of HADOOP-2845
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2927) Unit test fails on Windows:
org.apache.hadoop.fs.TestDU.testDU
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Shvachko updated HADOOP-2927:
----------------------------------------
Attachment: testDU.patch
The problem turned out to be in the test. This is how it works.
It first calculates the file system blockSize, then creates a file of size 2 * blockSize,
and then verifies that du for this file returns 2 * blockSize.
The blockSize is calculated by writing a small file (128 bytes) and calling
du on it, which is supposed to return a multiple of the block size in kilobytes.
In ntfs small files occupy only 1K (per du report) even though the block size is 4K.
NTFS is probably not allocating any blocks for small files and keeps their data directly in MFT.
Anyway, the test is somewhat inconsistent in that it verifies du based on the blockSize,
which is calculated using the same du.
I changed the test so that it now writes a 32K file and checks that du returns the same value.
The problem reported in HADOOP-2845 would be caught by such test.
I think this is a more general approach for testing DU.
> Unit test fails on Windows: org.apache.hadoop.fs.TestDU.testDU
> --------------------------------------------------------------
>
> Key: HADOOP-2927
> URL: https://issues.apache.org/jira/browse/HADOOP-2927
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.17.0
> Reporter: Mukund Madhugiri
> Assignee: Konstantin Shvachko
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: testDU.patch
>
>
> Unit test fails on Windows: org.apache.hadoop.fs.TestDU.testDU
> Here is the output from the test: org.apache.hadoop.fs.TestDU.testDU:
> junit.framework.AssertionFailedError: expected:<2048> but was:<4096>
> at org.apache.hadoop.fs.TestDU.testDU(TestDU.java:82)
> The failure points to the new test code in TestDU.java that just went in as part of HADOOP-2845
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.