You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "elharo (via GitHub)" <gi...@apache.org> on 2025/05/22 14:37:27 UTC
Re: [PR] fix: `DefaultModelInterpolator` PMD-Rule: `EmptyControlStatement` [maven]
elharo commented on code in PR #2373:
URL: https://github.com/apache/maven/pull/2373#discussion_r2102727275
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelInterpolator.java:
##########
@@ -109,8 +109,7 @@ private InnerInterpolator createInterpolator(
Model model, Path projectDir, ModelBuilderRequest request, ModelProblemCollector problems) {
Map<String, Optional<String>> cache = new HashMap<>();
- Function<String, Optional<String>> ucb =
- v -> Optional.ofNullable(callback(model, projectDir, request, problems, v));
+ Function<String, Optional<String>> ucb = v -> Optional.ofNullable(doCallback(model, projectDir, request, v));
Review Comment:
I can't follow this. perhaps if it were rewritten without using Java's line noise adjacent. so-called functional syntax it might be comprehensible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org