You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by maoling <gi...@git.apache.org> on 2018/08/31 11:36:00 UTC
[GitHub] zookeeper pull request #613: ZOOKEEPER-1823:LogFormatter should support prin...
GitHub user maoling opened a pull request:
https://github.com/apache/zookeeper/pull/613
ZOOKEEPER-1823:LogFormatter should support printing transaction data as a string
- It would be a useful addition for debuggling to show transaction data as strings with a option `-s `
- update the usage string to `USAGE: LogFormatter [-s] log_file` and add a short description for the `-s `
option
- for the issue [michim](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=michim) mentioned has been resolved,the test evidence has been included in the jira(Notice:we cannot `split(",")[1]` to replace the node data,because the node path can be like this `"/mao,ling"`)
- more details in [ZOOKEEPER-1823](https://issues.apache.org/jira/browse/ZOOKEEPER-1823).Thanks [rgs](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=rgs) for the origin work
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maoling/zookeeper ZOOKEEPER-1823
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/613.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #613
----
commit cf1f55bc023cde7921b6258597a832f6d097ea28
Author: maoling <ma...@...>
Date: 2018-08-31T11:12:05Z
ZOOKEEPER-1823:LogFormatter should support printing transaction data as a string
----
---
[GitHub] zookeeper issue #613: ZOOKEEPER-1823:zkTxnLogToolkit -dump should support pr...
Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/613
Merged to 3.5 and master. Thanks @maoling !
---
[GitHub] zookeeper issue #613: ZOOKEEPER-1823:LogFormatter should support printing tr...
Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/613
@maoling I intended to create TxnLogToolkit as a replacement for LogFormatter with some extra functionality. Do you mind checking that tool as well and see that this patch could be easily ported?
It would be nice to deco LogFormatter and keep only the new tool.
---
[GitHub] zookeeper issue #613: ZOOKEEPER-1823:zkTxnLogToolkit -dump should support pr...
Posted by maoling <gi...@git.apache.org>.
Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/613
@anmolnar Done.
---
[GitHub] zookeeper pull request #613: ZOOKEEPER-1823:zkTxnLogToolkit -dump should sup...
Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/613#discussion_r216257398
--- Diff: zookeeper-docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -2273,7 +2273,7 @@ server.3=zoo3:2888:3888</programlisting>
$ bin/zkTxnLogToolkit.sh
usage: TxnLogToolkit [-dhrv] txn_log_file_name
- -d,--dump Dump mode. Dump all entries of the log file. (this is the default)
+ -d,--dump Dump mode. Dump all entries of the log file with printing the content of a nodepath (default)
--- End diff --
This change is documentation only. Please update the help message as well.
---
[GitHub] zookeeper pull request #613: ZOOKEEPER-1823:zkTxnLogToolkit -dump should sup...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/613
---
[GitHub] zookeeper issue #613: ZOOKEEPER-1823:LogFormatter should support printing tr...
Posted by maoling <gi...@git.apache.org>.
Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/613
@anmolnar
Yes,I will try to transport this improment to `TxnLogToolkit`.
---